[v4,2/8] net/cxgbe: fix uint build error with musl libc

Message ID 20201105211716.25181-3-ncopa@alpinelinux.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v4,1/8] app/testpmd: fix uint build error with musl libc |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Natanael Copa Nov. 5, 2020, 9:17 p.m. UTC
  Improve portability by replacing non-standard 'uint' with 'unsigned int'

This solves the build error with musl libc:

In file included from ../drivers/net/cxgbe/cxgbe.h:9,
                 from ../drivers/net/cxgbe/cxgbe_ethdev.c:37:
../drivers/net/cxgbe/base/common.h:201:4: error: unknown type name 'uint'
  201 |    uint synmapen:1; /* SYN Map Enable */
      |    ^~~~

Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
Cc: stable@dpdk.org

Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
---
 drivers/net/cxgbe/base/common.h | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
  

Comments

Morten Brørup Nov. 6, 2020, 9:24 a.m. UTC | #1
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Natanael Copa
> Sent: Thursday, November 5, 2020 10:17 PM
> 
> Improve portability by replacing non-standard 'uint' with 'unsigned
> int'
> 
> This solves the build error with musl libc:
> 
> In file included from ../drivers/net/cxgbe/cxgbe.h:9,
>                  from ../drivers/net/cxgbe/cxgbe_ethdev.c:37:
> ../drivers/net/cxgbe/base/common.h:201:4: error: unknown type name
> 'uint'
>   201 |    uint synmapen:1; /* SYN Map Enable */
>       |    ^~~~
> 
> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> ---
>  drivers/net/cxgbe/base/common.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/cxgbe/base/common.h
> b/drivers/net/cxgbe/base/common.h
> index 8fe8e2a36..c1d09dfad 100644
> --- a/drivers/net/cxgbe/base/common.h
> +++ b/drivers/net/cxgbe/base/common.h
> @@ -201,15 +201,15 @@ struct rss_params {
>  	unsigned int mode;			/* RSS mode */
>  	union {
>  		struct {
> -			uint synmapen:1;	/* SYN Map Enable */
> -			uint syn4tupenipv6:1;	/* en 4-tuple IPv6 SYNs hash
> */
> -			uint syn2tupenipv6:1;	/* en 2-tuple IPv6 SYNs hash
> */
> -			uint syn4tupenipv4:1;	/* en 4-tuple IPv4 SYNs hash
> */
> -			uint syn2tupenipv4:1;	/* en 2-tuple IPv4 SYNs hash
> */
> -			uint ofdmapen:1;	/* Offload Map Enable */
> -			uint tnlmapen:1;	/* Tunnel Map Enable */
> -			uint tnlalllookup:1;	/* Tunnel All Lookup */
> -			uint hashtoeplitz:1;	/* use Toeplitz hash */
> +			unsigned int synmapen:1;	/* SYN Map Enable */
> +			unsigned int syn4tupenipv6:1;	/* en 4-tuple IPv6 SYNs
> hash */
> +			unsigned int syn2tupenipv6:1;	/* en 2-tuple IPv6 SYNs
> hash */
> +			unsigned int syn4tupenipv4:1;	/* en 4-tuple IPv4 SYNs
> hash */
> +			unsigned int syn2tupenipv4:1;	/* en 2-tuple IPv4 SYNs
> hash */
> +			unsigned int ofdmapen:1;	/* Offload Map Enable
> */
> +			unsigned int tnlmapen:1;	/* Tunnel Map Enable */
> +			unsigned int tnlalllookup:1;	/* Tunnel All Lookup */
> +			unsigned int hashtoeplitz:1;	/* use Toeplitz hash */
>  		} basicvirtual;
>  	} u;
>  };
> --
> 2.29.2
> 

Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
  

Patch

diff --git a/drivers/net/cxgbe/base/common.h b/drivers/net/cxgbe/base/common.h
index 8fe8e2a36..c1d09dfad 100644
--- a/drivers/net/cxgbe/base/common.h
+++ b/drivers/net/cxgbe/base/common.h
@@ -201,15 +201,15 @@  struct rss_params {
 	unsigned int mode;			/* RSS mode */
 	union {
 		struct {
-			uint synmapen:1;	/* SYN Map Enable */
-			uint syn4tupenipv6:1;	/* en 4-tuple IPv6 SYNs hash */
-			uint syn2tupenipv6:1;	/* en 2-tuple IPv6 SYNs hash */
-			uint syn4tupenipv4:1;	/* en 4-tuple IPv4 SYNs hash */
-			uint syn2tupenipv4:1;	/* en 2-tuple IPv4 SYNs hash */
-			uint ofdmapen:1;	/* Offload Map Enable */
-			uint tnlmapen:1;	/* Tunnel Map Enable */
-			uint tnlalllookup:1;	/* Tunnel All Lookup */
-			uint hashtoeplitz:1;	/* use Toeplitz hash */
+			unsigned int synmapen:1;	/* SYN Map Enable */
+			unsigned int syn4tupenipv6:1;	/* en 4-tuple IPv6 SYNs hash */
+			unsigned int syn2tupenipv6:1;	/* en 2-tuple IPv6 SYNs hash */
+			unsigned int syn4tupenipv4:1;	/* en 4-tuple IPv4 SYNs hash */
+			unsigned int syn2tupenipv4:1;	/* en 2-tuple IPv4 SYNs hash */
+			unsigned int ofdmapen:1;	/* Offload Map Enable */
+			unsigned int tnlmapen:1;	/* Tunnel Map Enable */
+			unsigned int tnlalllookup:1;	/* Tunnel All Lookup */
+			unsigned int hashtoeplitz:1;	/* use Toeplitz hash */
 		} basicvirtual;
 	} u;
 };