diff mbox series

[v2,1/2] net/ice: fix build error on lower version GCC

Message ID 20201103135200.41166-2-leyi.rong@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series fix build error on lower version GCC |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Leyi Rong Nov. 3, 2020, 1:51 p.m. UTC 
  Fix the build error when -march=skylake-avx512 is not supported on
lower version GCC.

Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path")

Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
 drivers/net/ice/meson.build | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

Comments

Bruce Richardson Nov. 3, 2020, 2:42 p.m. UTC | #1 
On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote:
> Fix the build error when -march=skylake-avx512 is not supported on
> lower version GCC.
> 
> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path")
> 
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Ferruh Yigit Nov. 3, 2020, 3:29 p.m. UTC | #2 
On 11/3/2020 2:42 PM, Bruce Richardson wrote:
> On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote:
>> Fix the build error when -march=skylake-avx512 is not supported on
>> lower version GCC.
>>
>> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path")
>>
>> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 

Squashed into relevant commit in next-net, thanks.

Indentation added to match 'ice' while merging.
Ferruh Yigit Nov. 3, 2020, 3:37 p.m. UTC | #3 
On 11/3/2020 3:29 PM, Ferruh Yigit wrote:
> On 11/3/2020 2:42 PM, Bruce Richardson wrote:
>> On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote:
>>> Fix the build error when -march=skylake-avx512 is not supported on
>>> lower version GCC.
>>>
>>> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path")
>>>
>>> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
>>
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>>
> 
> Squashed into relevant commit in next-net, thanks.
> 
> Indentation added to match 'ice' while merging.
> 

Hi Ali,

Can you please test the build of next-net/main one more time?

Thanks,
ferruh
Ali Alnubani Nov. 3, 2020, 3:42 p.m. UTC | #4 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, November 3, 2020 5:37 PM
> To: Bruce Richardson <bruce.richardson@intel.com>; Leyi Rong
> <leyi.rong@intel.com>; Ali Alnubani <alialnu@nvidia.com>
> Cc: qi.z.zhang@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower
> version GCC
> 
> On 11/3/2020 3:29 PM, Ferruh Yigit wrote:
> > On 11/3/2020 2:42 PM, Bruce Richardson wrote:
> >> On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote:
> >>> Fix the build error when -march=skylake-avx512 is not supported on
> >>> lower version GCC.
> >>>
> >>> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path")
> >>>
> >>> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> >>
> >> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >>
> >
> > Squashed into relevant commit in next-net, thanks.
> >
> > Indentation added to match 'ice' while merging.
> >
> 
> Hi Ali,
> 
> Can you please test the build of next-net/main one more time?
> 

Build is passing on "5b5f87681 app/testpmd: fix max Rx packet length for VLAN packets".

Thanks,
Ali
Ferruh Yigit Nov. 3, 2020, 3:57 p.m. UTC | #5 
On 11/3/2020 3:42 PM, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Tuesday, November 3, 2020 5:37 PM
>> To: Bruce Richardson <bruce.richardson@intel.com>; Leyi Rong
>> <leyi.rong@intel.com>; Ali Alnubani <alialnu@nvidia.com>
>> Cc: qi.z.zhang@intel.com; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower
>> version GCC
>>
>> On 11/3/2020 3:29 PM, Ferruh Yigit wrote:
>>> On 11/3/2020 2:42 PM, Bruce Richardson wrote:
>>>> On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote:
>>>>> Fix the build error when -march=skylake-avx512 is not supported on
>>>>> lower version GCC.
>>>>>
>>>>> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path")
>>>>>
>>>>> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
>>>>
>>>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>>>>
>>>
>>> Squashed into relevant commit in next-net, thanks.
>>>
>>> Indentation added to match 'ice' while merging.
>>>
>>
>> Hi Ali,
>>
>> Can you please test the build of next-net/main one more time?
>>
> 
> Build is passing on "5b5f87681 app/testpmd: fix max Rx packet length for VLAN packets".
> 

Thanks.
diff mbox series

Patch

diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build
index 7d54a49236..47d21678c2 100644
--- a/drivers/net/ice/meson.build
+++ b/drivers/net/ice/meson.build
@@ -46,12 +46,16 @@  if arch_subdir == 'x86'
 
 	if ice_avx512_cpu_support == true or ice_avx512_cc_support == true
 		cflags += ['-DCC_AVX512_SUPPORT']
+		avx512_args = [cflags, '-mavx512f', '-mavx512bw']
+		if cc.has_argument('-march=skylake-avx512')
+			avx512_args += '-march=skylake-avx512'
+		endif
 		ice_avx512_lib = static_library('ice_avx512_lib',
-				      'ice_rxtx_vec_avx512.c',
-				      dependencies: [static_rte_ethdev,
-					static_rte_kvargs, static_rte_hash],
-				      include_directories: includes,
-				      c_args: [cflags, '-march=skylake-avx512', '-mavx512f', '-mavx512bw'])
+				'ice_rxtx_vec_avx512.c',
+				dependencies: [static_rte_ethdev,
+				static_rte_kvargs, static_rte_hash],
+				include_directories: includes,
+				c_args: avx512_args)
 		objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c')
 	endif
 endif