diff mbox series

[2/2] tests/TestSuite_shutdown_api:change_thresholds:Ixgbe not support rx, only support tx

Message ID 20201103152344.1677878-3-linglix.chen@intel.com (mailing list archive)
State Accepted
Headers
Series tests/TestSuite_shutdown_api:change_thresholds:not support rx |

Commit Message

Lingli Chen Nov. 3, 2020, 3:23 p.m. UTC 
  DPDK-24129:1.Ixgbe not support rx, only support tx.
           2.foxville, powerville and springville not support txfree and txrs
           3.foxville--eth_igc_tx_queue_setup(): To improve 2.5G driver performance, consider setting the TX WTHRESH value to 4, 8, or 16.

Signed-off-by: Chen Linglix <linglix.chen@intel.com>
---
 tests/TestSuite_shutdown_api.py | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)
diff mbox series

Patch

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index edd1dcfa..1e98c640 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -706,34 +706,40 @@  class TestShutdownApi(TestCase):
     def test_change_thresholds(self):
         """
         Change RX/TX thresholds
+        DPDK-24129:1.CVL and FVL not support tx and rx
+                   2.Ixgbe not support rx, only support tx.
+                   3.foxville, powerville and springville not support txfree and txrs
         """
         self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
         self.dut.send_expect("set promisc all off", "testpmd>")
 
         self.dut.send_expect("port stop all", "testpmd> ", 100)
-        self.dut.send_expect("port config all txfreet 32", "testpmd> ")
-        self.dut.send_expect("port config all txrst 32", "testpmd> ")
+        if self.nic in ["sagepond","sageville","twinpond","niantic"]:
+            self.dut.send_expect("port config all txfreet 32", "testpmd> ")
+            self.dut.send_expect("port config all txrst 32", "testpmd> ")
         self.dut.send_expect("port config all rxfreet 32", "testpmd> ")
         self.dut.send_expect("port config all txpt 64", "testpmd> ")
         self.dut.send_expect("port config all txht 64", "testpmd> ")
-        self.dut.send_expect("port config all txwt 0", "testpmd> ")
-        self.dut.send_expect("port config all rxpt 64", "testpmd> ")
-        self.dut.send_expect("port config all rxht 64", "testpmd> ")
-        self.dut.send_expect("port config all rxwt 64", "testpmd> ")
+        if self.nic in ["foxville"]:
+            self.dut.send_expect("port config all txwt 16", "testpmd> ")
+        else:
+            self.dut.send_expect("port config all txwt 0", "testpmd> ")
+
         self.dut.send_expect("port start all", "testpmd> ", 100)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
         self.verify("RX free threshold=32" in out,
                     "RX descriptor not reconfigured properly")
-        self.verify("TX free threshold=32" in out,
+        if self.nic in ["sagepond","sageville","twinpond","niantic"]:
+            self.verify("TX free threshold=32" in out,
                     "TX descriptor not reconfigured properly")
-        self.verify("TX RS bit threshold=32" in out,
+            self.verify("TX RS bit threshold=32" in out,
                     "TX descriptor not reconfigured properly")
         self.verify("pthresh=64" in out, "TX descriptor not reconfigured properly")
         self.verify("hthresh=64" in out, "TX descriptor not reconfigured properly")
-        self.verify("wthresh=64" in out, "TX descriptor not reconfigured properly")
-        self.verify("pthresh=64" in out, "TX descriptor not reconfigured properly")
-        self.verify("hthresh=64" in out, "TX descriptor not reconfigured properly")
-        self.verify("wthresh=64" in out, "TX descriptor not reconfigured properly")
+        if self.nic in ["foxville"]:
+            self.verify("wthresh=16" in out, "TX descriptor not reconfigured properly")
+        else:
+            self.verify("wthresh=0" in out, "TX descriptor not reconfigured properly")
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("start", "testpmd> ")
         self.check_forwarding()