Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
Commit Message
Ophir Munk
Oct. 27, 2020, 11:23 p.m. UTC
From: Tal Shnaiderman <talshn@nvidia.com> Windows warns on missing function prototype get_if_name. To fix it - move the prototype to shared file mlx5.h and add missing definition IF_NAMESIZE to Windows mlx5_os.h file. Fixes: e9c0b96e3526 ("net/mlx5: move Linux ifname function") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> --- drivers/net/mlx5/linux/mlx5_os.h | 4 ---- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/windows/mlx5_os.h | 3 +++ 3 files changed, 4 insertions(+), 4 deletions(-)
Comments
28/10/2020 00:23, Ophir Munk: > From: Tal Shnaiderman <talshn@nvidia.com> > > Windows warns on missing function prototype get_if_name. To fix it - > move the prototype to shared file mlx5.h and add missing definition > IF_NAMESIZE to Windows mlx5_os.h file. > > Fixes: e9c0b96e3526 ("net/mlx5: move Linux ifname function") > Cc: stable@dpdk.org > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > --- [...] > --- a/drivers/net/mlx5/windows/mlx5_os.h > +++ b/drivers/net/mlx5/windows/mlx5_os.h > @@ -21,4 +21,7 @@ enum { > #ifndef ETOOMANYREFS > #define ETOOMANYREFS 109 /* Too many references: cannot splice */ > #endif > +#ifndef IF_NAMESIZE > +#define IF_NAMESIZE 128 > +#endif Should be in EAL.
diff --git a/drivers/net/mlx5/linux/mlx5_os.h b/drivers/net/mlx5/linux/mlx5_os.h index 759def2..e9cd511 100644 --- a/drivers/net/mlx5/linux/mlx5_os.h +++ b/drivers/net/mlx5/linux/mlx5_os.h @@ -17,8 +17,4 @@ enum { #define PCI_DRV_FLAGS (RTE_PCI_DRV_INTR_LSC | \ RTE_PCI_DRV_INTR_RMV | \ RTE_PCI_DRV_PROBE_AGAIN) - -/* mlx5_ethdev_os.c */ - -int mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[IF_NAMESIZE]); #endif /* RTE_PMD_MLX5_OS_H_ */ diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index b1385b8..6475fcc 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -976,6 +976,7 @@ int mlx5_dev_configure_rss_reta(struct rte_eth_dev *dev); /* mlx5_ethdev_os.c */ +int mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[IF_NAMESIZE]); unsigned int mlx5_ifindex(const struct rte_eth_dev *dev); int mlx5_get_mac(struct rte_eth_dev *dev, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]); int mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu); diff --git a/drivers/net/mlx5/windows/mlx5_os.h b/drivers/net/mlx5/windows/mlx5_os.h index 563cfa4..d21d4f2 100644 --- a/drivers/net/mlx5/windows/mlx5_os.h +++ b/drivers/net/mlx5/windows/mlx5_os.h @@ -21,4 +21,7 @@ enum { #ifndef ETOOMANYREFS #define ETOOMANYREFS 109 /* Too many references: cannot splice */ #endif +#ifndef IF_NAMESIZE +#define IF_NAMESIZE 128 +#endif #endif /* RTE_PMD_MLX5_OS_H_ */