diff mbox series

net/mlx5: tunnel offload code cleanup

Message ID 20201027161226.24041-1-getelson@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Andrew Rybchenko
Headers
Series net/mlx5: tunnel offload code cleanup |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Gregory Etelson Oct. 27, 2020, 4:12 p.m. UTC 
  Remove unused reference to rte_hash structure from PMD tunnel offload
code.

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
 drivers/net/mlx5/mlx5.h      | 1 -
 drivers/net/mlx5/mlx5_flow.c | 1 -
 2 files changed, 2 deletions(-)

Comments

Slava Ovsiienko Oct. 27, 2020, 4:29 p.m. UTC | #1 
> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Tuesday, October 27, 2020 18:12
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Eli Britstein
> <elibr@nvidia.com>; Oz Shlomo <ozsh@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: tunnel offload code cleanup
> 
> Remove unused reference to rte_hash structure from PMD tunnel offload
> code.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Raslan Darawsheh Oct. 27, 2020, 5:16 p.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Tuesday, October 27, 2020 6:12 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Eli Britstein
> <elibr@nvidia.com>; Oz Shlomo <ozsh@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: tunnel offload code cleanup
> 
> Remove unused reference to rte_hash structure from PMD tunnel offload
> code.
> 
Added missing fixes line:
Fixes: dc67aa65c698 ("net/mlx5: implement tunnel offload API")

> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5.h      | 1 -
>  drivers/net/mlx5/mlx5_flow.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> index 09026288fc..88bbd316f0 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -648,7 +648,6 @@ struct mlx5_dev_ctx_shared {
>  	/* UAR same-page access control required in 32bit implementations.
> */
>  #endif
>  	struct mlx5_hlist *flow_tbls;
> -	struct rte_hash *flow_tbl_map; /* app group-to-flow table map */
>  	struct mlx5_flow_tunnel_hub *tunnel_hub;
>  	/* Direct Rules tables for FDB, NIC TX+RX */
>  	void *esw_drop_action; /* Pointer to DR E-Switch drop action. */
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 02e19e83ae..082d886c74 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -19,7 +19,6 @@
>  #include <rte_flow_driver.h>
>  #include <rte_malloc.h>
>  #include <rte_ip.h>
> -#include <rte_hash.h>
> 
>  #include <mlx5_glue.h>
>  #include <mlx5_devx_cmds.h>
> --
> 2.28.0

Patch applied to next-net-mlx,
@ferruh.yigit@intel.com,
Can you kindly squash it into relevant commit in next-net ?

Kindest regards
Raslan Darawsheh
Andrew Rybchenko Oct. 28, 2020, 12:33 p.m. UTC | #3 
On 10/27/20 8:16 PM, Raslan Darawsheh wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Gregory Etelson <getelson@nvidia.com>
>> Sent: Tuesday, October 27, 2020 6:12 PM
>> To: dev@dpdk.org
>> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
>> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Eli Britstein
>> <elibr@nvidia.com>; Oz Shlomo <ozsh@nvidia.com>; Shahaf Shuler
>> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
>> Subject: [PATCH] net/mlx5: tunnel offload code cleanup
>>
>> Remove unused reference to rte_hash structure from PMD tunnel offload
>> code.
>>
> Added missing fixes line:
> Fixes: dc67aa65c698 ("net/mlx5: implement tunnel offload API")
> 
>> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
>> ---
>>  drivers/net/mlx5/mlx5.h      | 1 -
>>  drivers/net/mlx5/mlx5_flow.c | 1 -
>>  2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
>> index 09026288fc..88bbd316f0 100644
>> --- a/drivers/net/mlx5/mlx5.h
>> +++ b/drivers/net/mlx5/mlx5.h
>> @@ -648,7 +648,6 @@ struct mlx5_dev_ctx_shared {
>>  	/* UAR same-page access control required in 32bit implementations.
>> */
>>  #endif
>>  	struct mlx5_hlist *flow_tbls;
>> -	struct rte_hash *flow_tbl_map; /* app group-to-flow table map */
>>  	struct mlx5_flow_tunnel_hub *tunnel_hub;
>>  	/* Direct Rules tables for FDB, NIC TX+RX */
>>  	void *esw_drop_action; /* Pointer to DR E-Switch drop action. */
>> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
>> index 02e19e83ae..082d886c74 100644
>> --- a/drivers/net/mlx5/mlx5_flow.c
>> +++ b/drivers/net/mlx5/mlx5_flow.c
>> @@ -19,7 +19,6 @@
>>  #include <rte_flow_driver.h>
>>  #include <rte_malloc.h>
>>  #include <rte_ip.h>
>> -#include <rte_hash.h>
>>
>>  #include <mlx5_glue.h>
>>  #include <mlx5_devx_cmds.h>
>> --
>> 2.28.0
> 
> Patch applied to next-net-mlx,
> @ferruh.yigit@intel.com,
> Can you kindly squash it into relevant commit in next-net ?

Done, squashed it into relevant commit in next-net/main, thanks.
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 09026288fc..88bbd316f0 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -648,7 +648,6 @@  struct mlx5_dev_ctx_shared {
 	/* UAR same-page access control required in 32bit implementations. */
 #endif
 	struct mlx5_hlist *flow_tbls;
-	struct rte_hash *flow_tbl_map; /* app group-to-flow table map */
 	struct mlx5_flow_tunnel_hub *tunnel_hub;
 	/* Direct Rules tables for FDB, NIC TX+RX */
 	void *esw_drop_action; /* Pointer to DR E-Switch drop action. */
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 02e19e83ae..082d886c74 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -19,7 +19,6 @@ 
 #include <rte_flow_driver.h>
 #include <rte_malloc.h>
 #include <rte_ip.h>
-#include <rte_hash.h>
 
 #include <mlx5_glue.h>
 #include <mlx5_devx_cmds.h>