[v2] drivers/net: do not enforce RSS hash offload

  From: Alexander Kozyrev <akozyrev@mellanox.com>

Rx RSS hash offload should be controlled by the user
and should not be enforced by RSS multi-queue Rx mode.

Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")
Cc: stable@dpdk.org

Author: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx4/mlx4.c        | 3 ---
 drivers/net/mlx5/mlx5_ethdev.c | 3 ---
 2 files changed, 6 deletions(-)
  

Hi,

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Tuesday, October 27, 2020 5:15 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; arybchenko@solarflare.com; Matan
> Azrad <matan@nvidia.com>; Alexander Kozyrev <akozyrev@mellanox.com>
> Subject: [PATCH v2] drivers/net: do not enforce RSS hash offload
> 
> From: Alexander Kozyrev <akozyrev@mellanox.com>
> 
> Rx RSS hash offload should be controlled by the user
> and should not be enforced by RSS multi-queue Rx mode.
> 
> Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")
> Cc: stable@dpdk.org
> 
> Author: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  drivers/net/mlx4/mlx4.c        | 3 ---
>  drivers/net/mlx5/mlx5_ethdev.c | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index 34c2bbb373..d5d8c96351 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
>  	struct rte_flow_error error;
>  	int ret;
> 
> -	if (dev->data->dev_conf.rxmode.mq_mode &
> ETH_MQ_RX_RSS_FLAG)
> -		dev->data->dev_conf.rxmode.offloads |=
> DEV_RX_OFFLOAD_RSS_HASH;
> -
>  	/* Prepare internal flow rules. */
>  	ret = mlx4_flow_sync(priv, &error);
>  	if (ret) {
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c
> index fc04fc8224..6cadfe3eb0 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
>  		return -rte_errno;
>  	}
> 
> -	if (dev->data->dev_conf.rxmode.mq_mode &
> ETH_MQ_RX_RSS_FLAG)
> -		dev->data->dev_conf.rxmode.offloads |=
> DEV_RX_OFFLOAD_RSS_HASH;
> -
>  	memcpy(priv->rss_conf.rss_key,
>  	       use_app_rss_key ?
>  	       dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
> --
> 2.24.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh