From patchwork Tue Oct 27 13:24:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hunt, David" X-Patchwork-Id: 82327 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01547A04B5; Tue, 27 Oct 2020 14:24:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB7854C7A; Tue, 27 Oct 2020 14:24:45 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9B0012BFE; Tue, 27 Oct 2020 14:24:43 +0100 (CET) IronPort-SDR: S1QIAyprmtPdzC4eaQQ3ZzAhtlyQGBJNSVgKJeX1kWvf8GkmZGFTHZYuWNVink3Hv0gNC0Vn7a yzPlOCdS2c8A== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="168204347" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="168204347" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 06:24:18 -0700 IronPort-SDR: 9zFXQuAgGQnOhJSg2j82r00dtT4cSkEQ5sAgEq+JVO79FyOJ3ELlcYbWlOlNACzIsqbOzIVy6E F3Nwe9kUPItg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="360741168" Received: from silpixa00399952.ir.intel.com (HELO silpixa00399952.ger.corp.intel.com) ([10.237.222.38]) by FMSMGA003.fm.intel.com with ESMTP; 27 Oct 2020 06:24:16 -0700 From: David Hunt To: dev@dpdk.org Cc: david.hunt@intel.com, stable@dpdk.org Date: Tue, 27 Oct 2020 13:24:13 +0000 Message-Id: <20201027132413.23116-1-david.hunt@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201027125227.21946-1-david.hunt@intel.com> References: <20201027125227.21946-1-david.hunt@intel.com> Subject: [dpdk-dev] [PATCH v4] lib/power: remove set env deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove notice announcing an already-implemented change. In 19.05, rte_power_set_env was changed to return -1 in cases where the envorinment was already set up, and for the same release, a deprecation notice was added for the following commit: 'commit 5a5f3178d4a8 ("power: return error when environment already set")' This patch removes that notice. The API change was tested by calling rte_power_set_env twice. The first call succeeded, and the second call failed, as expected. Signed-off-by: David Hunt --- v1 initial version (with typo in the title) v2 fix typo but forgot --in-reply-to v3 add -in-reply-to v4 add in version info, and cc stable in case it needs to be backported Note: CC'ing stable in case the deprecation notice should also be removed from 19.11. It looks to me like the patch making the change and the patch adding the notice were both added in 19.11, so the notice is no longer needed in that verion. I didn't add a Fixes line to this patch as I believe the notice was correct, just adding both fix and notice in the same version was not strictly the right thing to have done at the time. --- doc/guides/rel_notes/deprecation.rst | 5 ----- 1 file changed, 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 76a83968c..ed82df52a 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -172,11 +172,6 @@ Deprecation Notices * metrics: The function ``rte_metrics_init`` will have a non-void return in order to notify errors instead of calling ``rte_exit``. -* power: ``rte_power_set_env`` function will no longer return 0 on attempt - to set new power environment if power environment was already initialized. - In this case the function will return -1 unless the environment is unset first - (using ``rte_power_unset_env``). Other function usage scenarios will not change. - * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific content. On Linux and FreeBSD, supported prior to DPDK 20.11, original structure will be kept until DPDK 21.11.