diff mbox series

common/sfc_efx/base: fix build breakage on clang 3.4.x

Message ID 1603800517-32207-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Andrew Rybchenko
Headers
Series common/sfc_efx/base: fix build breakage on clang 3.4.x |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-testing fail Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Andrew Rybchenko Oct. 27, 2020, 12:08 p.m. UTC 
  Remove duplicate typedef for efx_mae_actions_t.

Fixes: 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/fini APIs")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/common/sfc_efx/base/efx_impl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ali Alnubani Oct. 27, 2020, 2:55 p.m. UTC | #1 
Thanks Andrew.

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Andrew Rybchenko
> Sent: Tuesday, October 27, 2020 2:09 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on
> clang 3.4.x
> 
> Remove duplicate typedef for efx_mae_actions_t.
> 
> Fixes: 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/fini
> APIs")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  drivers/common/sfc_efx/base/efx_impl.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/common/sfc_efx/base/efx_impl.h
> b/drivers/common/sfc_efx/base/efx_impl.h
> index d8423d4..ed5b872 100644
> --- a/drivers/common/sfc_efx/base/efx_impl.h
> +++ b/drivers/common/sfc_efx/base/efx_impl.h
> @@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {
>  	uint16_t			emavp_tci_be;
>  } efx_mae_action_vlan_push_t;
> 
> -typedef struct efx_mae_actions_s {
> +struct efx_mae_actions_s {
>  	/* Bitmap of actions in spec, indexed by action type */
>  	uint32_t			emass_actions;
> 
> @@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s {
>  	    EFX_MAE_VLAN_PUSH_MAX_NTAGS];
>  	uint32_t			emass_mark_value;
>  	efx_mport_sel_t			emass_deliver_mport;
> -} efx_mae_actions_t;
> +};
> 
>  #endif /* EFSYS_OPT_MAE */
> 
> --
> 1.8.3.1

Tested-by: Ali Alnubani <alialnu@nvidia.com>
Andrew Rybchenko Oct. 27, 2020, 3:23 p.m. UTC | #2 
On 10/27/20 5:55 PM, Ali Alnubani wrote:
> Thanks Andrew.
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Andrew Rybchenko
>> Sent: Tuesday, October 27, 2020 2:09 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on
>> clang 3.4.x
>>
>> Remove duplicate typedef for efx_mae_actions_t.
>>
>> Fixes: 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/fini
>> APIs")
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>>  drivers/common/sfc_efx/base/efx_impl.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/common/sfc_efx/base/efx_impl.h
>> b/drivers/common/sfc_efx/base/efx_impl.h
>> index d8423d4..ed5b872 100644
>> --- a/drivers/common/sfc_efx/base/efx_impl.h
>> +++ b/drivers/common/sfc_efx/base/efx_impl.h
>> @@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {
>>  	uint16_t			emavp_tci_be;
>>  } efx_mae_action_vlan_push_t;
>>
>> -typedef struct efx_mae_actions_s {
>> +struct efx_mae_actions_s {
>>  	/* Bitmap of actions in spec, indexed by action type */
>>  	uint32_t			emass_actions;
>>
>> @@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s {
>>  	    EFX_MAE_VLAN_PUSH_MAX_NTAGS];
>>  	uint32_t			emass_mark_value;
>>  	efx_mport_sel_t			emass_deliver_mport;
>> -} efx_mae_actions_t;
>> +};
>>
>>  #endif /* EFSYS_OPT_MAE */
>>
>> --
>> 1.8.3.1
> 
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
> 

Squashed into corresponding changeset, thanks.
diff mbox series

Patch

diff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h
index d8423d4..ed5b872 100644
--- a/drivers/common/sfc_efx/base/efx_impl.h
+++ b/drivers/common/sfc_efx/base/efx_impl.h
@@ -1736,7 +1736,7 @@  struct efx_mae_match_spec_s {
 	uint16_t			emavp_tci_be;
 } efx_mae_action_vlan_push_t;
 
-typedef struct efx_mae_actions_s {
+struct efx_mae_actions_s {
 	/* Bitmap of actions in spec, indexed by action type */
 	uint32_t			emass_actions;
 
@@ -1746,7 +1746,7 @@  struct efx_mae_match_spec_s {
 	    EFX_MAE_VLAN_PUSH_MAX_NTAGS];
 	uint32_t			emass_mark_value;
 	efx_mport_sel_t			emass_deliver_mport;
-} efx_mae_actions_t;
+};
 
 #endif /* EFSYS_OPT_MAE */