diff mbox series

[v2] examples/qos_sched: update profile oversubscribe config file

Message ID 20201027092205.21325-1-savinay.dharmappa@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: David Marchand
Headers
Series [v2] examples/qos_sched: update profile oversubscribe config file |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Savinay Dharmappa Oct. 27, 2020, 9:22 a.m. UTC 
  update the profile_ov config file to support dynamic
update of subport rate.

Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
---
v2: renamed the commit subject.
---
 examples/qos_sched/profile_ov.cfg | 3 +++
 1 file changed, 3 insertions(+)

Comments

Cristian Dumitrescu Oct. 27, 2020, 9:45 a.m. UTC | #1 
> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Tuesday, October 27, 2020 9:22 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>; dev@dpdk.org
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Subject: [PATCH v2] examples/qos_sched: update profile oversubscribe
> config file
> 
> update the profile_ov config file to support dynamic
> update of subport rate.
> 
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> ---
> v2: renamed the commit subject.
> ---
>  examples/qos_sched/profile_ov.cfg | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/examples/qos_sched/profile_ov.cfg
> b/examples/qos_sched/profile_ov.cfg
> index ab509d28d7..14c89ae340 100644
> --- a/examples/qos_sched/profile_ov.cfg
> +++ b/examples/qos_sched/profile_ov.cfg
> @@ -11,6 +11,9 @@ number of subports per port = 1
>  number of pipes per subport = 32
>  queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
> 
> +subport 0-8 = 0
> +
> +[subport profile 0]
>  tb rate = 8400000           ; Bytes per second
>  tb size = 100000            ; Bytes
> 
> --
> 2.17.1

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Savinay Dharmappa Nov. 5, 2020, 9:39 a.m. UTC | #2 
-----Original Message-----
From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> 
Sent: Tuesday, October 27, 2020 3:16 PM
To: Dharmappa, Savinay <savinay.dharmappa@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org
Subject: RE: [PATCH v2] examples/qos_sched: update profile oversubscribe config file



> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Tuesday, October 27, 2020 9:22 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, 
> Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Subject: [PATCH v2] examples/qos_sched: update profile oversubscribe 
> config file
> 
> update the profile_ov config file to support dynamic update of subport 
> rate.
> 
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> ---
> v2: renamed the commit subject.
> ---
>  examples/qos_sched/profile_ov.cfg | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/examples/qos_sched/profile_ov.cfg
> b/examples/qos_sched/profile_ov.cfg
> index ab509d28d7..14c89ae340 100644
> --- a/examples/qos_sched/profile_ov.cfg
> +++ b/examples/qos_sched/profile_ov.cfg
> @@ -11,6 +11,9 @@ number of subports per port = 1  number of pipes per 
> subport = 32  queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
> 
> +subport 0-8 = 0
> +
> +[subport profile 0]
>  tb rate = 8400000           ; Bytes per second
>  tb size = 100000            ; Bytes
> 
> --
> 2.17.1

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Hi Thomas,
>> I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know
Thomas Monjalon Nov. 5, 2020, 10:11 a.m. UTC | #3 
05/11/2020 10:39, Dharmappa, Savinay:
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Hi Thomas,
> I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know

-rc2 was very busy, and examples were low priority.
Will look into examples for -rc3.
David Marchand Nov. 13, 2020, 1:58 p.m. UTC | #4 
On Thu, Nov 5, 2020 at 10:39 AM Dharmappa, Savinay
<savinay.dharmappa@intel.com> wrote:
> Hi Thomas,
> >> I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know

Please, pay attention when editing replies, this mail of yours added
Cristian token again in patchwork.

The commitlog is vague and gives no context.

I looked through patchwork and found:
https://patchwork.dpdk.org/patch/81666/
So, iiuc, you forgot to update those two examples configuration file
and documentations.

If so, please submit one patch fixing the qos_sched example (both
config and doc) and another patch for fixing the ip_pipeline (doc).
In both of them, describe with a Fixes: tag which commits are being fixed.
Savinay Dharmappa Nov. 17, 2020, 7:05 a.m. UTC | #5 
-----Original Message-----
From: David Marchand <david.marchand@redhat.com> 
Sent: Friday, November 13, 2020 7:28 PM
To: Dharmappa, Savinay <savinay.dharmappa@intel.com>
Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

On Thu, Nov 5, 2020 at 10:39 AM Dharmappa, Savinay <savinay.dharmappa@intel.com> wrote:
> Hi Thomas,
> >> I see that this patch is not applied on rc2. When can this will be 
> >> applied ? will it be part of rc3 ?. Please let me know

Please, pay attention when editing replies, this mail of yours added Cristian token again in patchwork.

The commitlog is vague and gives no context.

I looked through patchwork and found:
https://patchwork.dpdk.org/patch/81666/
So, iiuc, you forgot to update those two examples configuration file and documentations.

If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc).
In both of them, describe with a Fixes: tag which commits are being fixed.

>>  Instead of new patch shall I send v3 of this patch which has (both config and doc) and similarly for https://patchwork.dpdk.org/patch/81666/  patch to have only ip_pipeline (doc). Please let me know.
--
David Marchand
David Marchand Nov. 17, 2020, 7:21 a.m. UTC | #6 
On Tue, Nov 17, 2020 at 8:05 AM Dharmappa, Savinay
<savinay.dharmappa@intel.com> wrote:
> If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc).
> In both of them, describe with a Fixes: tag which commits are being fixed.
>
> >>  Instead of new patch shall I send v3 of this patch which has (both config and doc) and similarly for https://patchwork.dpdk.org/patch/81666/  patch to have only ip_pipeline (doc). Please let me know.

Yes, one patch for qos_shed and one patch for ip_pipeline.
diff mbox series

Patch

diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg
index ab509d28d7..14c89ae340 100644
--- a/examples/qos_sched/profile_ov.cfg
+++ b/examples/qos_sched/profile_ov.cfg
@@ -11,6 +11,9 @@  number of subports per port = 1
 number of pipes per subport = 32
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
 
+subport 0-8 = 0
+
+[subport profile 0]
 tb rate = 8400000           ; Bytes per second
 tb size = 100000            ; Bytes