[V2] tests/TestSuite_qinq_filter:insmod igb_uio create vf and add no_vec_eal_params
diff mbox series

Message ID 1603784425-8460-1-git-send-email-xix.zhang@intel.com
State Superseded
Headers show
Series
  • [V2] tests/TestSuite_qinq_filter:insmod igb_uio create vf and add no_vec_eal_params
Related show

Commit Message

Zhang, XiX Oct. 27, 2020, 7:40 a.m. UTC
v1:insmod igb_uio create vf and add no_vec_eal_params
v2:update EAL parameter force-max-simd-bitwidth=64  notes

Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
 tests/TestSuite_qinq_filter.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Comments

Zhang, XiX Oct. 27, 2020, 7:39 a.m. UTC | #1
Tested-by: Zhang, XiX <xix.zhang@intel.com>

> -----Original Message-----
> From: xizhan4x [mailto:xix.zhang@intel.com]
> Sent: Tuesday, October 27, 2020 3:40 PM
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: [dts][PATCH V2] tests/TestSuite_qinq_filter:insmod igb_uio create vf
> and add no_vec_eal_params
Ma, LihongX Oct. 29, 2020, 8:05 a.m. UTC | #2
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of xizhan4x
> Sent: Tuesday, October 27, 2020 3:40 PM
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: [dts] [PATCH V2] tests/TestSuite_qinq_filter:insmod igb_uio create
> vf and add no_vec_eal_params
> 
> v1:insmod igb_uio create vf and add no_vec_eal_params v2:update EAL
> parameter force-max-simd-bitwidth=64  notes
> 
> Signed-off-by: xizhan4x <xix.zhang@intel.com>
> ---
>  tests/TestSuite_qinq_filter.py | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/TestSuite_qinq_filter.py
> b/tests/TestSuite_qinq_filter.py index 91a2d7a..0d90627 100644
> -
> -        self.dut.send_expect(r'%s -c %s -n 4 -- -i \
> +        #add a EAL parameter --force-max-simd-bitwidth=64,it disable all
> vector code paths.
> +        no_vec_eal_params='--force-max-simd-bitwidth=64'
> +        self.dut.send_expect(r'%s -c %s -n 4 %s -- -i \
>                                 --portmask=%s --port-topology=loop \
> -                               --rxq=4 --txq=4  --disable-rss' %
> (self.path, self.coreMask, self.portMask),
> +                               --rxq=4 --txq=4  --disable-rss' %
> + (self.path, self.coreMask, no_vec_eal_params, self.portMask),
>                                 "testpmd> ", 30)

I think all the cases in the suite will tested on no-vector path, but there is only one case add this parameter, could you check it?

>          """
>          qinq filter packet received by assign VF queues
>          """
> +        self.dut.setup_modules(self.target,'igb_uio',None)
>          self.config_vfs(dutRxPortId, 2)
>          vf_list = self.dut.ports_info[dutRxPortId]['sriov_vfs_pci']

If it is needed setup module of igb_uio, it is better add to the place where need it.
Eg: before self.dut.generate_sriov_vfs_by_port(port_id, vfs, 'igb_uio')

Regards,
Ma,lihong
Zhang, XiX Nov. 3, 2020, 2:20 a.m. UTC | #3
Hi lihong
> > +        self.dut.setup_modules(self.target,'igb_uio',None)
self.dut.setup_modules  Just to load  igb_uio , TestSuite_qinq_filter.py  Contains and used self.dut.generate_sriov_vfs_by_port  methods

    def config_vfs(self, port_id, vfs):
        """
        if vfs is 0, call destroy_sriov_vfs_by_port in dut for destory vf.
        if vfs > 0, call generate_sriov_vfs_by_port generate vf and bind igb_uio to vf
        """
        if vfs:
            self.dut.generate_sriov_vfs_by_port(port_id, vfs, 'igb_uio')
            for port in self.dut.ports_info[port_id]['vfs_port']:
                port.bind_driver('igb_uio')
        else:
            self.dut.destroy_sriov_vfs_by_port(port_id)




> -----Original Message-----
> From: Ma, LihongX
> Sent: Thursday, October 29, 2020 4:05 PM
> To: Zhang, XiX <xix.zhang@intel.com>; dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>
> Subject: RE: [dts] [PATCH V2] tests/TestSuite_qinq_filter:insmod igb_uio create
> vf and add no_vec_eal_params
> 
> 
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of xizhan4x
> > Sent: Tuesday, October 27, 2020 3:40 PM
> > To: dts@dpdk.org
> > Cc: Zhang, XiX <xix.zhang@intel.com>
> > Subject: [dts] [PATCH V2] tests/TestSuite_qinq_filter:insmod igb_uio
> > create vf and add no_vec_eal_params
>

 
> If it is needed setup module of igb_uio, it is better add to the place where need
> it.
> Eg: before self.dut.generate_sriov_vfs_by_port(port_id, vfs, 'igb_uio')
> 
> Regards,
> Ma,lihong

Patch
diff mbox series

diff --git a/tests/TestSuite_qinq_filter.py b/tests/TestSuite_qinq_filter.py
index 91a2d7a..0d90627 100644
--- a/tests/TestSuite_qinq_filter.py
+++ b/tests/TestSuite_qinq_filter.py
@@ -72,8 +72,6 @@  class TestQinqFilter(TestCase):
         
         cores = self.dut.get_core_list('1S/2C/1T')
         self.coreMask = utils.create_mask(cores)
-        self.dut.set_build_options({'RTE_LIBRTE_I40E_INC_VECTOR': 'n'})
-        self.dut.build_install_dpdk(self.target)
         self.path=self.dut.apps_name['test-pmd']
         
     def vlan_send_packet(self, vlans):
@@ -142,10 +140,11 @@  class TestQinqFilter(TestCase):
         """
         Enable receipt of dual VLAN packets
         """
-        
-        self.dut.send_expect(r'%s -c %s -n 4 -- -i \
+        #add a EAL parameter --force-max-simd-bitwidth=64,it disable all vector code paths.
+        no_vec_eal_params='--force-max-simd-bitwidth=64'
+        self.dut.send_expect(r'%s -c %s -n 4 %s -- -i \
                                --portmask=%s --port-topology=loop \
-                               --rxq=4 --txq=4  --disable-rss' % (self.path, self.coreMask, self.portMask),
+                               --rxq=4 --txq=4  --disable-rss' % (self.path, self.coreMask, no_vec_eal_params, self.portMask),
                                "testpmd> ", 30)
         self.dut.send_expect("vlan set extend on %s" % dutRxPortId, "testpmd> ")
         self.dut.send_expect("vlan set strip on %s" % dutRxPortId, "testpmd> ")
@@ -195,6 +194,7 @@  class TestQinqFilter(TestCase):
         """
         qinq filter packet received by assign VF queues
         """
+        self.dut.setup_modules(self.target,'igb_uio',None)
         self.config_vfs(dutRxPortId, 2)
         vf_list = self.dut.ports_info[dutRxPortId]['sriov_vfs_pci']
         self.verify(len(vf_list) == 2, 'config 2 vf failed: %s' % str(vf_list))
@@ -348,5 +348,4 @@  class TestQinqFilter(TestCase):
         """
         Run after each test suite.
         """
-        self.dut.set_build_options({'RTE_LIBRTE_I40E_INC_VECTOR': 'y'})
-        self.dut.build_install_dpdk(self.target)
+        pass