examples/pipeline: fix resource leak
diff mbox series

Message ID 20201026212355.8769-1-cristian.dumitrescu@intel.com
State Accepted, archived
Delegated to: David Marchand
Headers show
Series
  • examples/pipeline: fix resource leak
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Dumitrescu, Cristian Oct. 26, 2020, 9:23 p.m. UTC
Coverity issue: 363041
Fixes: 5074e1d551 ("examples/pipeline: add configuration commands")

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/pipeline/cli.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

David Marchand Oct. 29, 2020, 4:31 p.m. UTC | #1
On Mon, Oct 26, 2020 at 10:24 PM Cristian Dumitrescu
<cristian.dumitrescu@intel.com> wrote:
>
> Coverity issue: 363041
> Fixes: 5074e1d551 ("examples/pipeline: add configuration commands")
>
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks.

Patch
diff mbox series

diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
index 8ac6b3f5f..d0150cfcf 100644
--- a/examples/pipeline/cli.c
+++ b/examples/pipeline/cli.c
@@ -779,6 +779,18 @@  cmd_pipeline_build(char **tokens,
 	}
 }
 
+static void
+table_entry_free(struct rte_swx_table_entry *entry)
+{
+	if (!entry)
+		return;
+
+	free(entry->key);
+	free(entry->key_mask);
+	free(entry->action_data);
+	free(entry);
+}
+
 static const char cmd_pipeline_table_update_help[] =
 "pipeline <pipeline_name> table <table_name> update <file_name_add> "
 "<file_name_delete> <file_name_default>";
@@ -885,6 +897,7 @@  cmd_pipeline_table_update(char **tokens,
 			status = rte_swx_ctl_pipeline_table_entry_add(p->ctl,
 				table_name,
 				entry);
+			table_entry_free(entry);
 			if (status) {
 				snprintf(out, out_size,
 					"Invalid entry in file %s at line %u",
@@ -914,6 +927,7 @@  cmd_pipeline_table_update(char **tokens,
 			status = rte_swx_ctl_pipeline_table_entry_delete(p->ctl,
 				table_name,
 				entry);
+			table_entry_free(entry);
 			if (status)  {
 				snprintf(out, out_size,
 					"Invalid entry in file %s at line %u",
@@ -942,6 +956,7 @@  cmd_pipeline_table_update(char **tokens,
 			status = rte_swx_ctl_pipeline_table_default_entry_add(p->ctl,
 				table_name,
 				entry);
+			table_entry_free(entry);
 			if (status) {
 				snprintf(out, out_size,
 					"Invalid entry in file %s at line %u",