[1/1] eventdev: increase MAX QUEUES PER DEV to 255
diff mbox series

Message ID 1603728068-1617-1-git-send-email-timothy.mcdaniel@intel.com
State Accepted, archived
Delegated to: Jerin Jacob
Headers show
Series
  • [1/1] eventdev: increase MAX QUEUES PER DEV to 255
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Timothy McDaniel Oct. 26, 2020, 4:01 p.m. UTC
DLB supports a total of 256 queues, 128 load balanced queues
and 128 directed queues.

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 config/rte_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jerin Jacob Oct. 28, 2020, 9:35 a.m. UTC | #1
On Mon, Oct 26, 2020 at 9:29 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> DLB supports a total of 256 queues, 128 load balanced queues
> and 128 directed queues.
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
>  config/rte_config.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/rte_config.h b/config/rte_config.h
> index 8aa46a1..b78c6aa 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -71,7 +71,7 @@
>
>  /* eventdev defines */
>  #define RTE_EVENT_MAX_DEVS 16
> -#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
> +#define RTE_EVENT_MAX_QUEUES_PER_DEV 255

If it is 0..255 then this value should be 256. Isn't it?


>  #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
>  #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
>  #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
> --
> 2.6.4
>
Timothy McDaniel Oct. 28, 2020, 2:52 p.m. UTC | #2
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Wednesday, October 28, 2020 4:36 AM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dpdk-dev
> <dev@dpdk.org>; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> Jerin Jacob <jerinj@marvell.com>
> Subject: Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV
> to 255
> 
> On Mon, Oct 26, 2020 at 9:29 PM Timothy McDaniel
> <timothy.mcdaniel@intel.com> wrote:
> >
> > DLB supports a total of 256 queues, 128 load balanced queues
> > and 128 directed queues.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> > ---
> >  config/rte_config.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/config/rte_config.h b/config/rte_config.h
> > index 8aa46a1..b78c6aa 100644
> > --- a/config/rte_config.h
> > +++ b/config/rte_config.h
> > @@ -71,7 +71,7 @@
> >
> >  /* eventdev defines */
> >  #define RTE_EVENT_MAX_DEVS 16
> > -#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
> > +#define RTE_EVENT_MAX_QUEUES_PER_DEV 255
> 
> If it is 0..255 then this value should be 256. Isn't it?
> 

.max_event_queues is a uint8_t, so we could not go to 256 without changing the
data structure.

> 
> >  #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
> >  #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
> >  #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
> > --
> > 2.6.4
> >
Eads, Gage Oct. 30, 2020, 8:03 p.m. UTC | #3
> -----Original Message-----
> From: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Sent: Monday, October 26, 2020 11:01 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> jerinj@marvell.com
> Subject: [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
> 
> DLB supports a total of 256 queues, 128 load balanced queues
> and 128 directed queues.
> 
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>

Perhaps you can increase the queues-related fields to uint16_t in the future
to allow for the full 256, but in the meantime:

Reviewed-by: Gage Eads <gage.eads@intel.com>

Thanks,
Gage
Jerin Jacob Oct. 31, 2020, 10:58 a.m. UTC | #4
On Sat, Oct 31, 2020 at 1:34 AM Eads, Gage <gage.eads@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> > Sent: Monday, October 26, 2020 11:01 AM
> > To: Richardson, Bruce <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> > <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> > jerinj@marvell.com
> > Subject: [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255
> >
> > DLB supports a total of 256 queues, 128 load balanced queues
> > and 128 directed queues.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
>
> Perhaps you can increase the queues-related fields to uint16_t in the future
> to allow for the full 256, but in the meantime:
>
> Reviewed-by: Gage Eads <gage.eads@intel.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied to dpdk-next-eventdev/for-main with following git commit change, Thanks.

commit e79fdca1baaff30cbdd423b1fec82087cafc0b83 (HEAD -> for-main,
origin/for-main, origin/HEAD)
Author: Timothy McDaniel <timothy.mcdaniel@intel.com>
Date:   Mon Oct 26 11:01:08 2020 -0500

    eventdev: increase max queues configuration

    DLB supports a total of 256 queues, 128 load balanced queues
    and 128 directed queues. Increase RTE_EVENT_MAX_QUEUES_PER_DEV
    to max possible uint_8_t max value.

    Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
    Reviewed-by: Gage Eads <gage.eads@intel.com>
    Acked-by: Jerin Jacob <jerinj@marvell.com>


>
> Thanks,
> Gage

Patch
diff mbox series

diff --git a/config/rte_config.h b/config/rte_config.h
index 8aa46a1..b78c6aa 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -71,7 +71,7 @@ 
 
 /* eventdev defines */
 #define RTE_EVENT_MAX_DEVS 16
-#define RTE_EVENT_MAX_QUEUES_PER_DEV 64
+#define RTE_EVENT_MAX_QUEUES_PER_DEV 255
 #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32
 #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
 #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32