From patchwork Mon Oct 26 15:35:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thinh Tran X-Patchwork-Id: 82201 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 836E7A04DC; Mon, 26 Oct 2020 16:35:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 793B11E2B; Mon, 26 Oct 2020 16:35:26 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 5DB5E1D9E for ; Mon, 26 Oct 2020 16:35:25 +0100 (CET) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09QFXjhx159611 for ; Mon, 26 Oct 2020 11:35:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id; s=pp1; bh=e74vLaPmeJ94SRRjZKBW+2MgKFYqwAZTGg08evdVi1A=; b=awbTHVVRpMeTigQBLjsX5Ue+Gb91cop17xu9+JAqaJaDX6fhvWbjIoEwTf+hlGU/mKj5 X9y/3AvcYkc54PIJ7Fl1fwQYO00RW5U7meb6H80L0aaliMCDlo+2pgcANNiDOdv0KgHH J1wgBxm/iA8YnmBN0m/HYKxBKnH4PodOJHEZ+HQMc2kCmCSVAH//puW3cYLpAYp/rUlk kqyzfbMTI9P56MlKXqBFYa8Z6FFkEv8RIuCIXBtake1rEiP7FPGIOBZeCRodWxA+aAMY n3EFdhOWX3WNRMVTQrbSFk58zUuVf1EnH+5JrTqKltLsfJys+kTIkLmyme8jM730jaT6 WQ== Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com with ESMTP id 34duwd2chg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Oct 2020 11:35:23 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 09QFKsD2026303 for ; Mon, 26 Oct 2020 15:35:23 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma01wdc.us.ibm.com with ESMTP id 34cbw8gn38-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Oct 2020 15:35:23 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 09QFZHg715204616 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Oct 2020 15:35:17 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 316096E052; Mon, 26 Oct 2020 15:35:22 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E25E26E054; Mon, 26 Oct 2020 15:35:21 +0000 (GMT) Received: from ltc17u1.stglabs.ibm.com (unknown [9.114.216.145]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 26 Oct 2020 15:35:21 +0000 (GMT) From: Thinh Tran To: dts@dpdk.org Cc: thinhtr@linux.vnet.ibm.com Date: Mon, 26 Oct 2020 11:35:13 -0400 Message-Id: <20201026153513.137685-1-thinhtr@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.737 definitions=2020-10-26_08:2020-10-26, 2020-10-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 mlxlogscore=742 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 phishscore=0 adultscore=0 suspectscore=1 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010260107 Subject: [dts] [PATCH V2] framework/tester closing scapy session raise exception X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" v1: Sending control "^c" during closing the scapy sessions raised the time- out exception for expecting scapy prompt ">>> " return causing the failure during setup. Simply sending "quit" to exit scapy gratefully instead. v2: Sending "quit()" function insteadt of "quit" Signed-off-by: Thinh Tran --- framework/tester.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/framework/tester.py b/framework/tester.py index ca179b2..c515123 100644 --- a/framework/tester.py +++ b/framework/tester.py @@ -868,8 +868,7 @@ class Tester(Crb): if self.scapy_sessions_li: for i in self.scapy_sessions_li: if i.session.isalive(): - i.session.send_expect("^c", ">>> ", timeout=2) - i.session.send_expect("^d", "#", timeout=2) + i.session.send_expect("quit()", "#", timeout=2) i.session.close() self.scapy_sessions_li.clear()