mlx5: add ConnectX-7 and Bluefield-3 device IDs
diff mbox series

Message ID 20201026114147.9566-1-rasland@nvidia.com
State Accepted
Delegated to: Raslan Darawsheh
Headers show
Series
  • mlx5: add ConnectX-7 and Bluefield-3 device IDs
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Raslan Darawsheh Oct. 26, 2020, 11:41 a.m. UTC
This adds the ConnectX-7 and Bluefield-3 device ids to the list of
supported Mellanox devices that run the MLX5 PMDs.
The devices is still in development stage.

Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
 drivers/common/mlx5/mlx5_common.h | 2 ++
 drivers/net/mlx5/mlx5.c           | 8 ++++++++
 drivers/regex/mlx5/mlx5_regex.c   | 4 ++++
 drivers/vdpa/mlx5/mlx5_vdpa.c     | 8 ++++++++
 4 files changed, 22 insertions(+)

Comments

Slava Ovsiienko Oct. 26, 2020, 1:39 p.m. UTC | #1
> -----Original Message-----
> From: Raslan Darawsheh <rasland@nvidia.com>
> Sent: Monday, October 26, 2020 13:42
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Shy Shyman <shys@nvidia.com>
> Subject: [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs
> 
> This adds the ConnectX-7 and Bluefield-3 device ids to the list of supported
> Mellanox devices that run the MLX5 PMDs.
> The devices is still in development stage.
> 
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> ---
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Raslan Darawsheh Oct. 27, 2020, 7:25 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Raslan Darawsheh
> Sent: Monday, October 26, 2020 1:42 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Shy Shyman <shys@nvidia.com>
> Subject: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device
> IDs
> 
> This adds the ConnectX-7 and Bluefield-3 device ids to the list of
> supported Mellanox devices that run the MLX5 PMDs.
> The devices is still in development stage.
> 
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> ---
>  drivers/common/mlx5/mlx5_common.h | 2 ++
>  drivers/net/mlx5/mlx5.c           | 8 ++++++++
>  drivers/regex/mlx5/mlx5_regex.c   | 4 ++++
>  drivers/vdpa/mlx5/mlx5_vdpa.c     | 8 ++++++++
>  4 files changed, 22 insertions(+)
> 
> diff --git a/drivers/common/mlx5/mlx5_common.h
> b/drivers/common/mlx5/mlx5_common.h
> index ed44a45a81..93985bf2c9 100644
> --- a/drivers/common/mlx5/mlx5_common.h
> +++ b/drivers/common/mlx5/mlx5_common.h
> @@ -132,6 +132,8 @@ enum {
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF = 0xa2d6,
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX6LX = 0x101f,
> +	PCI_DEVICE_ID_MELLANOX_CONNECTX7 = 0x1021,
> +	PCI_DEVICE_ID_MELLANOX_CONNECTX7BF = 0Xa2dc,
>  };
> 
>  /* Maximum number of simultaneous unicast MAC addresses. */
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index 77aeac85c5..0316253ca8 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -2122,6 +2122,14 @@ static const struct rte_pci_id mlx5_pci_id_map[] =
> {
>  		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
>  				PCI_DEVICE_ID_MELLANOX_CONNECTX6LX)
>  	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
> +	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
> +	},
>  	{
>  		.vendor_id = 0
>  	}
> diff --git a/drivers/regex/mlx5/mlx5_regex.c
> b/drivers/regex/mlx5/mlx5_regex.c
> index 35e8ea0a9a..17590b937c 100644
> --- a/drivers/regex/mlx5/mlx5_regex.c
> +++ b/drivers/regex/mlx5/mlx5_regex.c
> @@ -254,6 +254,10 @@ static const struct rte_pci_id
> mlx5_regex_pci_id_map[] = {
>  		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> 
> 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
>  	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
> +	},
>  	{
>  		.vendor_id = 0
>  	}
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c
> b/drivers/vdpa/mlx5/mlx5_vdpa.c
> index a8f3e4b1de..2d88633bfd 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
> @@ -825,6 +825,14 @@ static const struct rte_pci_id
> mlx5_vdpa_pci_id_map[] = {
>  		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> 
> 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
>  	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
> +	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
> +	},
>  	{
>  		.vendor_id = 0
>  	}
> --
> 2.17.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
Ferruh Yigit Oct. 29, 2020, 3:26 p.m. UTC | #3
On 10/26/2020 11:41 AM, Raslan Darawsheh wrote:
> This adds the ConnectX-7 and Bluefield-3 device ids to the list of
> supported Mellanox devices that run the MLX5 PMDs.
> The devices is still in development stage.
> 

I assume you don't want to add these new device support to the documentation or 
to the web page, but what do you think adding it to the driver documentation 
with this device under development note, or experimental support etc?

> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>

<...>
Raslan Darawsheh Nov. 1, 2020, 9:08 a.m. UTC | #4
Hi Ferruh,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, October 29, 2020 5:26 PM
> To: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Shy Shyman <shys@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3
> device IDs
> 
> On 10/26/2020 11:41 AM, Raslan Darawsheh wrote:
> > This adds the ConnectX-7 and Bluefield-3 device ids to the list of
> > supported Mellanox devices that run the MLX5 PMDs.
> > The devices is still in development stage.
> >
> 
> I assume you don't want to add these new device support to the
> documentation or
> to the web page, but what do you think adding it to the driver
> documentation
> with this device under development note, or experimental support etc?
> 
It's about that we haven't tried the PMD with these NIC's yet, so announcing that it has support for them
without knowing that we don't really have any issues (even 0 level issue) I don't think its OK to add such documentation.

I think once we'll have the proper testing done for them, we can add them to all necessary documentations

> > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> 
> <...>


Kindest regards,
Raslan Darawsheh
Ferruh Yigit Nov. 2, 2020, 10:52 a.m. UTC | #5
On 11/1/2020 9:08 AM, Raslan Darawsheh wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Thursday, October 29, 2020 5:26 PM
>> To: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
>> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
>> <viacheslavo@nvidia.com>; Shy Shyman <shys@nvidia.com>
>> Subject: Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3
>> device IDs
>>
>> On 10/26/2020 11:41 AM, Raslan Darawsheh wrote:
>>> This adds the ConnectX-7 and Bluefield-3 device ids to the list of
>>> supported Mellanox devices that run the MLX5 PMDs.
>>> The devices is still in development stage.
>>>
>>
>> I assume you don't want to add these new device support to the
>> documentation or
>> to the web page, but what do you think adding it to the driver
>> documentation
>> with this device under development note, or experimental support etc?
>>
> It's about that we haven't tried the PMD with these NIC's yet, so announcing that it has support for them
> without knowing that we don't really have any issues (even 0 level issue) I don't think its OK to add such documentation.
> 
> I think once we'll have the proper testing done for them, we can add them to all necessary documentations
> 

OK

Patch
diff mbox series

diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h
index ed44a45a81..93985bf2c9 100644
--- a/drivers/common/mlx5/mlx5_common.h
+++ b/drivers/common/mlx5/mlx5_common.h
@@ -132,6 +132,8 @@  enum {
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF = 0xa2d6,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6LX = 0x101f,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX7 = 0x1021,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX7BF = 0Xa2dc,
 };
 
 /* Maximum number of simultaneous unicast MAC addresses. */
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 77aeac85c5..0316253ca8 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -2122,6 +2122,14 @@  static const struct rte_pci_id mlx5_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6LX)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}
diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c
index 35e8ea0a9a..17590b937c 100644
--- a/drivers/regex/mlx5/mlx5_regex.c
+++ b/drivers/regex/mlx5/mlx5_regex.c
@@ -254,6 +254,10 @@  static const struct rte_pci_id mlx5_regex_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
index a8f3e4b1de..2d88633bfd 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
@@ -825,6 +825,14 @@  static const struct rte_pci_id mlx5_vdpa_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}