crypto/dpaa2_sec: remove dead code
diff mbox series

Message ID 20201023074304.25247-1-david.marchand@redhat.com
State Accepted
Delegated to: akhil goyal
Headers show
Series
  • crypto/dpaa2_sec: remove dead code
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

David Marchand Oct. 23, 2020, 7:43 a.m. UTC
RTE_LIBRTE_SECURITY_TEST never existed, the variable under this check is
never used.

Fixes: e117c18a1dbe ("crypto/dpaa2_sec: restructure session management")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Akhil Goyal Oct. 23, 2020, 8:35 a.m. UTC | #1
> RTE_LIBRTE_SECURITY_TEST never existed, the variable under this check is
> never used.
> 
> Fixes: e117c18a1dbe ("crypto/dpaa2_sec: restructure session management")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
This test is part of our internal tree in NXP. I think it got accidently added while rebasing
at some point. Thanks for cleaning this up.

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Akhil Goyal Oct. 28, 2020, 11:46 a.m. UTC | #2
> RTE_LIBRTE_SECURITY_TEST never existed, the variable under this check is
> never used.
> 
> Fixes: e117c18a1dbe ("crypto/dpaa2_sec: restructure session management")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Applied to dpdk-next-crypto

Thanks.

Patch
diff mbox series

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index afcd6bd063..7577803823 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -2818,12 +2818,6 @@  dpaa2_sec_ipsec_proto_init(struct rte_crypto_cipher_xform *cipher_xform,
 	return 0;
 }
 
-#ifdef RTE_LIBRTE_SECURITY_TEST
-static uint8_t aes_cbc_iv[] = {
-	0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
-	0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f };
-#endif
-
 static int
 dpaa2_sec_set_ipsec_session(struct rte_cryptodev *dev,
 			    struct rte_security_session_conf *conf,