diff mbox series

doc/guides: fix reference to x32 architecture

Message ID 20201022080143.20371-1-david.marchand@redhat.com (mailing list archive)
State Rejected, archived
Delegated to: David Marchand
Headers
Series doc/guides: fix reference to x32 architecture |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

David Marchand Oct. 22, 2020, 8:01 a.m. UTC 
  There is no CONFIG_RTE_ARCH_X86_64_32.
The original intention was probably to refer to x32.

Fixes: 36032e46be40 ("doc: add coding style")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 doc/guides/contributing/design.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson Oct. 22, 2020, 8:25 a.m. UTC | #1 
On Thu, Oct 22, 2020 at 10:01:43AM +0200, David Marchand wrote:
> There is no CONFIG_RTE_ARCH_X86_64_32.
> The original intention was probably to refer to x32.
> 
> Fixes: 36032e46be40 ("doc: add coding style")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  doc/guides/contributing/design.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
> index 5fe7f63942..54dad08846 100644
> --- a/doc/guides/contributing/design.rst
> +++ b/doc/guides/contributing/design.rst
> @@ -47,7 +47,7 @@ Per Architecture Sources
>  The following config options can be used:
>  
>  * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
> -* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> +* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
>  

With make gone, I don't believe that there is an RTE_ARCH_X86_X32 now
either.
David Marchand Oct. 22, 2020, 8:32 a.m. UTC | #2 
On Thu, Oct 22, 2020 at 10:26 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
> > index 5fe7f63942..54dad08846 100644
> > --- a/doc/guides/contributing/design.rst
> > +++ b/doc/guides/contributing/design.rst
> > @@ -47,7 +47,7 @@ Per Architecture Sources
> >  The following config options can be used:
> >
> >  * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
> > -* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> > +* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> >
>
> With make gone, I don't believe that there is an RTE_ARCH_X86_X32 now
> either.

As Thomas pointed offlist, this should go with Ciara series anyway.
I'll drop this patch.
diff mbox series

Patch

diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
index 5fe7f63942..54dad08846 100644
--- a/doc/guides/contributing/design.rst
+++ b/doc/guides/contributing/design.rst
@@ -47,7 +47,7 @@  Per Architecture Sources
 The following config options can be used:
 
 * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
-* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
+* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
 
 Per Execution Environment Sources
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~