framework/tester closing scapy session raise exception
diff mbox series

Message ID 20201021181146.125603-1-thinhtr@linux.vnet.ibm.com
State Changes Requested
Headers show
Series
  • framework/tester closing scapy session raise exception
Related show

Commit Message

Thinh Tran Oct. 21, 2020, 6:11 p.m. UTC
Sending control "^c" during  closing the scapy sessions raised the time-
  out exception for expecting scapy prompt ">>> " return causing the failure
  during setup.
  Simply sending "quit" to exit scapy gratefully instead.

Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
 framework/tester.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Ma, LihongX Oct. 22, 2020, 8:12 a.m. UTC | #1
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Thinh Tran
> Sent: Thursday, October 22, 2020 2:12 AM
> To: dts@dpdk.org
> Cc: thinhtr@linux.vnet.ibm.com
> Subject: [dts] [PATCH] framework/tester closing scapy session raise
> exception
> 
>   Sending control "^c" during  closing the scapy sessions raised the time-
>   out exception for expecting scapy prompt ">>> " return causing the
> failure
>   during setup.
>   Simply sending "quit" to exit scapy gratefully instead.
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
>  framework/tester.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/framework/tester.py b/framework/tester.py index
> ca179b2..a7a68b5 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -868,8 +868,7 @@ class Tester(Crb):
>          if self.scapy_sessions_li:
>              for i in self.scapy_sessions_li:
>                  if i.session.isalive():
> -                    i.session.send_expect("^c", ">>> ", timeout=2)
> -                    i.session.send_expect("^d", "#", timeout=2)
> +                    i.session.send_expect("quit", "# ", timeout=2)
>                      i.session.close()
>              self.scapy_sessions_li.clear()
> 
> --
> 2.17.0

The session is scapy session that start the scapy, so can not use the command quit, should use "quit()"

Regards,
Ma,lihong

Patch
diff mbox series

diff --git a/framework/tester.py b/framework/tester.py
index ca179b2..a7a68b5 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -868,8 +868,7 @@  class Tester(Crb):
         if self.scapy_sessions_li:
             for i in self.scapy_sessions_li:
                 if i.session.isalive():
-                    i.session.send_expect("^c", ">>> ", timeout=2)
-                    i.session.send_expect("^d", "#", timeout=2)
+                    i.session.send_expect("quit", "# ", timeout=2)
                     i.session.close()
             self.scapy_sessions_li.clear()