diff mbox series

config: fix kni build

Message ID 20201020091743.192709-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series config: fix kni build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson Oct. 20, 2020, 9:17 a.m. UTC 
  When building kernel modules such as kni, the "config" directory is not
passed as a standard path in the EXTRA_CFLAGS value, meaning that the
rte_compatibility_defines.h is not found from rte_config.h. However, since
both headers are in the same directory, we can just use quotes rather than
angle-brackets to ensure the second header is always found if the first is.

Fixes: b0b672aeadaa ("build: add defines for compatibility with make build")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 config/rte_config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand Oct. 20, 2020, 10:03 a.m. UTC | #1 
On Tue, Oct 20, 2020 at 11:19 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> When building kernel modules such as kni, the "config" directory is not
> passed as a standard path in the EXTRA_CFLAGS value, meaning that the
> rte_compatibility_defines.h is not found from rte_config.h. However, since
> both headers are in the same directory, we can just use quotes rather than
> angle-brackets to ensure the second header is always found if the first is.
>
> Fixes: b0b672aeadaa ("build: add defines for compatibility with make build")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
David Marchand Oct. 20, 2020, 10:31 a.m. UTC | #2 
On Tue, Oct 20, 2020 at 12:03 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Oct 20, 2020 at 11:19 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > When building kernel modules such as kni, the "config" directory is not
> > passed as a standard path in the EXTRA_CFLAGS value, meaning that the
> > rte_compatibility_defines.h is not found from rte_config.h. However, since
> > both headers are in the same directory, we can just use quotes rather than
> > angle-brackets to ensure the second header is always found if the first is.
> >
> > Fixes: b0b672aeadaa ("build: add defines for compatibility with make build")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/config/rte_config.h b/config/rte_config.h
index f64b4d634..8aa46a1aa 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -13,7 +13,7 @@ 
 #define _RTE_CONFIG_H_
 
 #include <rte_build_config.h>
-#include <rte_compatibility_defines.h>
+#include "rte_compatibility_defines.h"
 
 /* legacy defines */
 #ifdef RTE_EXEC_ENV_LINUX