From patchwork Mon Oct 19 21:09:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chautru, Nicolas" X-Patchwork-Id: 81404 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48638A04DC; Mon, 19 Oct 2020 23:14:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07E3FC9E0; Mon, 19 Oct 2020 23:14:02 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D5E0AC8FE for ; Mon, 19 Oct 2020 23:13:59 +0200 (CEST) IronPort-SDR: w/0cqcTwJRuOEqrsmkN91RmdHq65sXdLN/CFtBbmpCZbCtgN7jNUVS6zVDEn3uR/bZN6gYZyo3 immNzP0zRhyg== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="164492005" X-IronPort-AV: E=Sophos;i="5.77,395,1596524400"; d="scan'208";a="164492005" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2020 14:13:56 -0700 IronPort-SDR: 8jwFFhsH1+ytCfJv3RT5BwdC4IX2tR6/QkuVPmkkrTo6YCI3LJX2KmIsapxZA6MGTrvo6WzRSz t66WmW8+V5Ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,395,1596524400"; d="scan'208";a="320413443" Received: from skx-5gnr-sc12-4.sc.intel.com ([172.25.69.210]) by orsmga006.jf.intel.com with ESMTP; 19 Oct 2020 14:13:55 -0700 From: Nicolas Chautru To: dev@dpdk.org, akhil.goyal@nxp.com Cc: bruce.richardson@intel.com, trix@redhat.com, Nicolas Chautru Date: Mon, 19 Oct 2020 14:09:57 -0700 Message-Id: <1603141797-230055-2-git-send-email-nicolas.chautru@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1603141797-230055-1-git-send-email-nicolas.chautru@intel.com> References: <1603141797-230055-1-git-send-email-nicolas.chautru@intel.com> Subject: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity reported dead code for a few error checks which are indeed not reachable. Coverity issue: 363451, 363454, 363455 Signed-off-by: Nicolas Chautru Reviewed-by: Tom Rix --- drivers/baseband/acc100/rte_acc100_pmd.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 47ddbae..5e663a6 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -2519,9 +2519,6 @@ r++; } - if (unlikely(desc == NULL)) - return current_enqueued_cbs; - #ifdef RTE_LIBRTE_BBDEV_DEBUG if (check_mbuf_total_left(mbuf_total_left) != 0) return -EINVAL; @@ -3076,9 +3073,6 @@ r++; } - if (unlikely(desc == NULL)) - return current_enqueued_cbs; - #ifdef RTE_LIBRTE_BBDEV_DEBUG if (check_mbuf_total_left(mbuf_total_left) != 0) return -EINVAL; @@ -3181,9 +3175,6 @@ r++; } - if (unlikely(desc == NULL)) - return current_enqueued_cbs; - #ifdef RTE_LIBRTE_BBDEV_DEBUG if (check_mbuf_total_left(mbuf_total_left) != 0) return -EINVAL;