From patchwork Fri Oct 16 02:03:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junyu Jiang X-Patchwork-Id: 81017 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7E48A04DB; Fri, 16 Oct 2020 04:12:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B3BC1E999; Fri, 16 Oct 2020 04:12:30 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C06361E98E; Fri, 16 Oct 2020 04:12:27 +0200 (CEST) IronPort-SDR: pVDc/4IazQ/apbRf++Cuc9KLvVuSEcpa8A722bMfQjkdGIA3zi34sTwt2Djw3i5mxY1F5q24lX wOErGMT/M9Wg== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="153427532" X-IronPort-AV: E=Sophos;i="5.77,381,1596524400"; d="scan'208";a="153427532" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 19:12:22 -0700 IronPort-SDR: F4hKirhvbzfhVEHl6YmKA5bKxuDXNcElyeDuYqsiCa22Jl05rtYvG1uio1wd2SW2XaW0HZ1R4R wYeSULWCKIFw== X-IronPort-AV: E=Sophos;i="5.77,381,1596524400"; d="scan'208";a="531499962" Received: from unknown (HELO intel.sh.intel.com) ([10.239.255.60]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 19:12:18 -0700 From: Junyu Jiang To: dev@dpdk.org Cc: Suanming Mou , Ferruh Yigit , Beilei Xing , Wenzhuo Lu , Junyu Jiang , stable@dpdk.org Date: Fri, 16 Oct 2020 02:03:10 +0000 Message-Id: <20201016020310.51272-1-junyux.jiang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201014083005.64428-1-junyux.jiang@intel.com> References: <20201014083005.64428-1-junyux.jiang@intel.com> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix flow flush with invalid port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no error info displayed when running flow flush command with invalid port. This patch fixed the issue. Fixes: 2a449871a12d ("app/testpmd: align behaviour of multi-port detach") Cc: stable@dpdk.org Signed-off-by: Junyu Jiang Reviewed-by: Suanming Mou Reviewed-by: Ferruh Yigit --- app/test-pmd/config.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index fe31a9d52..541952ab8 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1772,19 +1772,22 @@ int port_flow_flush(portid_t port_id) { struct rte_flow_error error; - struct rte_port *port = &ports[port_id]; + struct rte_port *port; int ret = 0; + if (port_id_is_invalid(port_id, ENABLED_WARN) || + port_id == (portid_t)RTE_PORT_ALL) + return -EINVAL; + + port = &ports[port_id]; + if (port->flow_list == NULL) return ret; /* Poisoning to make sure PMDs update it in case of error. */ memset(&error, 0x44, sizeof(error)); if (rte_flow_flush(port_id, &error)) { - ret = port_flow_complain(&error); - if (port_id_is_invalid(port_id, DISABLED_WARN) || - port_id == (portid_t)RTE_PORT_ALL) - return ret; + port_flow_complain(&error); } while (port->flow_list) {