[v3,3/3] test/event_crypto_adapter: free resources during exit

Message ID 20201007052629.28566-4-adwivedi@marvell.com (mailing list archive)
State Changes Requested, archived
Delegated to: Jerin Jacob
Headers
Series Bug fixes in event crypto adapter test |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Ankur Dwivedi Oct. 7, 2020, 5:26 a.m. UTC
  The resources held by crypto adapter should be freed when the
test suite exits.

Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
---
 app/test/test_event_crypto_adapter.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
  

Comments

Gujjar, Abhinandan S Oct. 8, 2020, 7:26 a.m. UTC | #1
acked-by: abhinandan.gujjar@intel.com

> -----Original Message-----
> From: Ankur Dwivedi <adwivedi@marvell.com>
> Sent: Wednesday, October 7, 2020 10:56 AM
> To: dev@dpdk.org
> Cc: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; jerinj@marvell.com;
> anoobj@marvell.com; Ankur Dwivedi <adwivedi@marvell.com>
> Subject: [PATCH v3 3/3] test/event_crypto_adapter: free resources during exit
> 
> The resources held by crypto adapter should be freed when the test suite exits.
> 
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---
>  app/test/test_event_crypto_adapter.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 87a67139d..d6fbbfdde 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -899,6 +899,27 @@ testsuite_setup(void)
>  	return TEST_SUCCESS;
>  }
> 
> +static void
> +crypto_adapter_teardown(void)
> +{
> +	int ret;
> +
> +	ret = rte_event_crypto_adapter_stop(TEST_ADAPTER_ID);
> +	if (ret < 0)
> +		RTE_LOG(ERR, USER1, "Failed to stop adapter!");
> +
> +	ret = rte_event_crypto_adapter_queue_pair_del(TEST_ADAPTER_ID,
> +					TEST_CDEV_ID, TEST_CDEV_QP_ID);
> +	if (ret < 0)
> +		RTE_LOG(ERR, USER1, "Failed to delete queue pair!");
> +
> +	ret = rte_event_crypto_adapter_free(TEST_ADAPTER_ID);
> +	if (ret < 0)
> +		RTE_LOG(ERR, USER1, "Failed to free adapter!");
> +
> +	crypto_adapter_setup_done = 0;
> +}
> +
>  static void
>  crypto_teardown(void)
>  {
> @@ -941,6 +962,7 @@ eventdev_teardown(void)  static void
>  testsuite_teardown(void)
>  {
> +	crypto_adapter_teardown();
>  	crypto_teardown();
>  	eventdev_teardown();
>  }
> --
> 2.28.0
  

Patch

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 87a67139d..d6fbbfdde 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -899,6 +899,27 @@  testsuite_setup(void)
 	return TEST_SUCCESS;
 }
 
+static void
+crypto_adapter_teardown(void)
+{
+	int ret;
+
+	ret = rte_event_crypto_adapter_stop(TEST_ADAPTER_ID);
+	if (ret < 0)
+		RTE_LOG(ERR, USER1, "Failed to stop adapter!");
+
+	ret = rte_event_crypto_adapter_queue_pair_del(TEST_ADAPTER_ID,
+					TEST_CDEV_ID, TEST_CDEV_QP_ID);
+	if (ret < 0)
+		RTE_LOG(ERR, USER1, "Failed to delete queue pair!");
+
+	ret = rte_event_crypto_adapter_free(TEST_ADAPTER_ID);
+	if (ret < 0)
+		RTE_LOG(ERR, USER1, "Failed to free adapter!");
+
+	crypto_adapter_setup_done = 0;
+}
+
 static void
 crypto_teardown(void)
 {
@@ -941,6 +962,7 @@  eventdev_teardown(void)
 static void
 testsuite_teardown(void)
 {
+	crypto_adapter_teardown();
 	crypto_teardown();
 	eventdev_teardown();
 }