maintainers: New Reviewer entry type added to MAINTAINERS
diff mbox series

Message ID 20201001143030.9194-1-trix@redhat.com
State New
Delegated to: Thomas Monjalon
Headers show
Series
  • maintainers: New Reviewer entry type added to MAINTAINERS
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch success coding style OK

Commit Message

Tom Rix Oct. 1, 2020, 2:30 p.m. UTC
From: Tom Rix <trix@redhat.com>

Copied from the Linux kernel MAINTAINERS file.
A Reviewer is designated person who wishes to review changes
in areas of interest.

Added self as Reviewer for baseband.

I am a Linux kernel Reviewer for the fpga n3000/vista creek which
has several bitstream based baseband devices.  So I want to help
out here as well.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Chautru, Nicolas Oct. 1, 2020, 9:22 p.m. UTC | #1
Hi Tom, 

Thanks for the help. 
Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of. 
https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=

Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>

> -----Original Message-----
> From: trix@redhat.com <trix@redhat.com>
> Sent: Thursday, October 1, 2020 7:31 AM
> To: thomas@monjalon.net; Chautru, Nicolas <nicolas.chautru@intel.com>
> Cc: dev@dpdk.org; Tom Rix <trix@redhat.com>
> Subject: [PATCH] maintainers: New Reviewer entry type added to
> MAINTAINERS
> 
> From: Tom Rix <trix@redhat.com>
> 
> Copied from the Linux kernel MAINTAINERS file.
> A Reviewer is designated person who wishes to review changes in areas of
> interest.
> 
> Added self as Reviewer for baseband.
> 
> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
> several bitstream based baseband devices.  So I want to help out here as
> well.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  MAINTAINERS | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c0abbe0fc..30faf2455 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17,7 +17,8 @@ Descriptions of section entries:
>  	X: Files and directories exclusion, same rules as F:
>  	K: Keyword regex pattern to match content.
>  	   One regex pattern per line. Multiple K: lines acceptable.
> -
> +	R: Designated *Reviewer*: FullName <address@domain>
> +	   These reviewers should be CCed on patches.
> 
>  General Project Administration
>  ------------------------------
> @@ -392,6 +393,7 @@ F: lib/librte_ethdev/rte_mtr*
> 
>  Baseband API - EXPERIMENTAL
>  M: Nicolas Chautru <nicolas.chautru@intel.com>
> +R: Tom Rix <trix@redhat.com>
>  T: git://dpdk.org/next/dpdk-next-crypto
>  F: lib/librte_bbdev/
>  F: doc/guides/prog_guide/bbdev.rst
> --
> 2.18.1
Thomas Monjalon Oct. 1, 2020, 9:54 p.m. UTC | #2
01/10/2020 23:22, Chautru, Nicolas:
> From: trix@redhat.com <trix@redhat.com>
> > From: Tom Rix <trix@redhat.com>
> > 
> > Copied from the Linux kernel MAINTAINERS file.
> > A Reviewer is designated person who wishes to review changes in areas of
> > interest.
> > 
> > Added self as Reviewer for baseband.
> > 
> > I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
> > several bitstream based baseband devices.  So I want to help out here as
> > well.
> > 
> > Signed-off-by: Tom Rix <trix@redhat.com>
> 
> Thanks for the help. 
> Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of. 
> https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=
> 
> Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
[...]
> >  Baseband API - EXPERIMENTAL
> >  M: Nicolas Chautru <nicolas.chautru@intel.com>
> > +R: Tom Rix <trix@redhat.com>

I don't understand the need of differenciating maintainer and reviewer.
If you are trusted enough, why not just being co-maintainer?
Tom Rix Oct. 2, 2020, 2:59 p.m. UTC | #3
On 10/1/20 2:54 PM, Thomas Monjalon wrote:
> 01/10/2020 23:22, Chautru, Nicolas:
>> From: trix@redhat.com <trix@redhat.com>
>>> From: Tom Rix <trix@redhat.com>
>>>
>>> Copied from the Linux kernel MAINTAINERS file.
>>> A Reviewer is designated person who wishes to review changes in areas of
>>> interest.
>>>
>>> Added self as Reviewer for baseband.
>>>
>>> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
>>> several bitstream based baseband devices.  So I want to help out here as
>>> well.
>>>
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>> Thanks for the help. 
>> Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of. 
>> https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=
>>
>> Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
> [...]
>>>  Baseband API - EXPERIMENTAL
>>>  M: Nicolas Chautru <nicolas.chautru@intel.com>
>>> +R: Tom Rix <trix@redhat.com>
> I don't understand the need of differenciating maintainer and reviewer.
> If you are trusted enough, why not just being co-maintainer?
>
I want to help out with the reviews, the reviewer type makes clear this level of commitment.

Maintainer is the next, higher level of commitment.


Trust wise, this would allow the maintainer verify the reviewer does have the bandwidth to be responsive

and effective before committing to sharing responsibility.

Tom

>
Thomas Monjalon Oct. 2, 2020, 3:41 p.m. UTC | #4
02/10/2020 16:59, Tom Rix:
> 
> On 10/1/20 2:54 PM, Thomas Monjalon wrote:
> > 01/10/2020 23:22, Chautru, Nicolas:
> >> From: trix@redhat.com <trix@redhat.com>
> >>> From: Tom Rix <trix@redhat.com>
> >>>
> >>> Copied from the Linux kernel MAINTAINERS file.
> >>> A Reviewer is designated person who wishes to review changes in areas of
> >>> interest.
> >>>
> >>> Added self as Reviewer for baseband.
> >>>
> >>> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
> >>> several bitstream based baseband devices.  So I want to help out here as
> >>> well.
> >>>
> >>> Signed-off-by: Tom Rix <trix@redhat.com>
> >> Thanks for the help. 
> >> Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of. 
> >> https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=
> >>
> >> Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > [...]
> >>>  Baseband API - EXPERIMENTAL
> >>>  M: Nicolas Chautru <nicolas.chautru@intel.com>
> >>> +R: Tom Rix <trix@redhat.com>
> > I don't understand the need of differenciating maintainer and reviewer.
> > If you are trusted enough, why not just being co-maintainer?
> >
> I want to help out with the reviews, the reviewer type makes clear this level of commitment.
> 
> Maintainer is the next, higher level of commitment.
> 
> 
> Trust wise, this would allow the maintainer verify the reviewer does have the bandwidth to be responsive
> 
> and effective before committing to sharing responsibility.

Sorry I fail to understand.
My understanding is that you want to be Cc
but not committing for responsibility.
Would it be the same if you create a mail filter on your side?

This model is really not clear to me so I'm reluctant to add
such new category until I understand the benefit.
Tom Rix Oct. 2, 2020, 4:35 p.m. UTC | #5
On 10/2/20 8:41 AM, Thomas Monjalon wrote:
> 02/10/2020 16:59, Tom Rix:
>> On 10/1/20 2:54 PM, Thomas Monjalon wrote:
>>> 01/10/2020 23:22, Chautru, Nicolas:
>>>> From: trix@redhat.com <trix@redhat.com>
>>>>> From: Tom Rix <trix@redhat.com>
>>>>>
>>>>> Copied from the Linux kernel MAINTAINERS file.
>>>>> A Reviewer is designated person who wishes to review changes in areas of
>>>>> interest.
>>>>>
>>>>> Added self as Reviewer for baseband.
>>>>>
>>>>> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
>>>>> several bitstream based baseband devices.  So I want to help out here as
>>>>> well.
>>>>>
>>>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>>> Thanks for the help. 
>>>> Note that they are a few other BBDEV patches in flight for 20.11 on top of the acc100 PMD that you may want to be aware of. 
>>>> https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=
>>>>
>>>> Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
>>> [...]
>>>>>  Baseband API - EXPERIMENTAL
>>>>>  M: Nicolas Chautru <nicolas.chautru@intel.com>
>>>>> +R: Tom Rix <trix@redhat.com>
>>> I don't understand the need of differenciating maintainer and reviewer.
>>> If you are trusted enough, why not just being co-maintainer?
>>>
>> I want to help out with the reviews, the reviewer type makes clear this level of commitment.
>>
>> Maintainer is the next, higher level of commitment.
>>
>>
>> Trust wise, this would allow the maintainer verify the reviewer does have the bandwidth to be responsive
>>
>> and effective before committing to sharing responsibility.
> Sorry I fail to understand.
> My understanding is that you want to be Cc
> but not committing for responsibility.
> Would it be the same if you create a mail filter on your side?
>
> This model is really not clear to me so I'm reluctant to add
> such new category until I understand the benefit.
>
That's fine, i will change the patch and use the existing process.

Tom

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index c0abbe0fc..30faf2455 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17,7 +17,8 @@  Descriptions of section entries:
 	X: Files and directories exclusion, same rules as F:
 	K: Keyword regex pattern to match content.
 	   One regex pattern per line. Multiple K: lines acceptable.
-
+	R: Designated *Reviewer*: FullName <address@domain>
+	   These reviewers should be CCed on patches.
 
 General Project Administration
 ------------------------------
@@ -392,6 +393,7 @@  F: lib/librte_ethdev/rte_mtr*
 
 Baseband API - EXPERIMENTAL
 M: Nicolas Chautru <nicolas.chautru@intel.com>
+R: Tom Rix <trix@redhat.com>
 T: git://dpdk.org/next/dpdk-next-crypto
 F: lib/librte_bbdev/
 F: doc/guides/prog_guide/bbdev.rst