checkpatch: suppress fallthrough warning
diff mbox series

Message ID 20200925161345.23209-1-stephen@networkplumber.org
State Rejected
Delegated to: David Marchand
Headers show
Series
  • checkpatch: suppress fallthrough warning
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Sept. 25, 2020, 4:13 p.m. UTC
The DPDK does not have (or want to use) the same fallthrough
wrapper as the Linux kernel.  Therefore silence the warning.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand Sept. 25, 2020, 4:41 p.m. UTC | #1
On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The DPDK does not have (or want to use) the same fallthrough
> wrapper as the Linux kernel.  Therefore silence the warning.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  devtools/checkpatches.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 78a408ef9823..923ff6f7d9ee 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
>  PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
                       ^^
This token is already set here.
Is there an issue with this?


>  SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
>  LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
>  options="$options $DPDK_CHECKPATCH_OPTIONS"
>
>  print_usage () {
> --
> 2.27.0
>
Stephen Hemminger Sept. 25, 2020, 5:13 p.m. UTC | #2
On Fri, 25 Sep 2020 18:41:40 +0200
David Marchand <david.marchand@redhat.com> wrote:

> On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The DPDK does not have (or want to use) the same fallthrough
> > wrapper as the Linux kernel.  Therefore silence the warning.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Never mind; note to self look first...

Didn't see that it was already set. Maybe the issue is that the
scans from patchwork are still using older version of the DPDK script?

Did a dummy patch just now with main branch and dpdk-checkpatch is
correctly suppressing the warning. But recent patches submitted
to mailing list are getting checkpatch warnings.
David Marchand Sept. 26, 2020, 8:47 a.m. UTC | #3
On Fri, Sep 25, 2020 at 7:13 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 25 Sep 2020 18:41:40 +0200
> David Marchand <david.marchand@redhat.com> wrote:
>
> > On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > >
> > > The DPDK does not have (or want to use) the same fallthrough
> > > wrapper as the Linux kernel.  Therefore silence the warning.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Never mind; note to self look first...
>
> Didn't see that it was already set. Maybe the issue is that the
> scans from patchwork are still using older version of the DPDK script?

Ah yes.
I updated it on the server.

Patch
diff mbox series

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 78a408ef9823..923ff6f7d9ee 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -33,7 +33,7 @@  VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
 PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
-NEW_TYPEDEFS,COMPARISON_TO_NULL"
+NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
 options="$options $DPDK_CHECKPATCH_OPTIONS"
 
 print_usage () {