From patchwork Thu Sep 24 12:40:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 78739 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF152A04B1; Thu, 24 Sep 2020 14:41:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7BC221DED1; Thu, 24 Sep 2020 14:41:22 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id A478E1DE99; Thu, 24 Sep 2020 14:41:21 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.150]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 14BFF20088; Thu, 24 Sep 2020 12:41:21 +0000 (UTC) Received: from us4-mdac16-38.at1.mdlocal (unknown [10.110.51.53]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 138C1800A3; Thu, 24 Sep 2020 12:41:21 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.33]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id AE1FE100052; Thu, 24 Sep 2020 12:41:20 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 7612D340067; Thu, 24 Sep 2020 12:41:20 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Sep 2020 13:41:07 +0100 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:41:07 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCf7uK022878; Thu, 24 Sep 2020 13:41:07 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 34C241613A9; Thu, 24 Sep 2020 13:41:07 +0100 (BST) From: Andrew Rybchenko To: CC: Igor Romanov , Date: Thu, 24 Sep 2020 13:40:58 +0100 Message-ID: <1600951259-28983-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25674.003 X-TM-AS-Result: No-0.330000-8.000000-10 X-TMASE-MatchedRID: kZZGRAph+5+bMghIM3wNl32PoiXxUAcXBnIRIVcCWN8oFW8VuxQzlYGV P6OXoWthPI8SZp0SyHPhidLmkO138aKgpS1QMZdluwdUMMznEA9KgIbix5+XxFjBUeMsjed6QBz oPKhLasiBvWVSrpdRLu7mo8mU3fMpCCLgd2TBNZrHmyDJSEsI21B1e7/F/vq5Rf+V8wb93nJZPx FWRZUqLmbAAJXwP/klgDLqnrRlXrZ8nn9tnqel2K6NVEWSRWyblK3GpxUPFaGlvuABOov23NA1v qVVDah6eFvG6UCnNws/bPcWuqIG81WyTXcAZMk7Dz0ogNXVeAdTcA2k3ux+tZO89326TkFV8Oyc cFNBL2TKhETi2//sjuP9Cb59K8ACZrS+A8PszW9A/zCH/Tq5HQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-0.330000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25674.003 X-MDID: 1600951281-2HGYEV-eMNTW Subject: [dpdk-dev] [PATCH 1/2] net/sfc: fix RSS hash flag when offload is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Igor Romanov Do not set RSS hash flag in the received mbufs when RSS hash offload is not enabled, which means that RSS hash value is invalid. Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_rx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index a62ce4a17d..dccafb163a 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/drivers/net/sfc/sfc_rx.c @@ -1155,7 +1155,8 @@ sfc_rx_qinit(struct sfc_adapter *sa, unsigned int sw_index, info.batch_max = encp->enc_rx_batch_max; info.prefix_size = encp->enc_rx_prefix_size; - if (rss->hash_support == EFX_RX_HASH_AVAILABLE && rss->channels > 0) + if (rss->hash_support == EFX_RX_HASH_AVAILABLE && rss->channels > 0 && + (offloads & DEV_RX_OFFLOAD_RSS_HASH)) info.flags |= SFC_RXQ_FLAG_RSS_HASH; info.rxq_entries = rxq_info->entries;