From patchwork Tue Sep 22 17:30:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Richardson X-Patchwork-Id: 78438 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACE05A04B5; Tue, 22 Sep 2020 19:30:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 011F11DAB8; Tue, 22 Sep 2020 19:30:42 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 1C70A1D648 for ; Tue, 22 Sep 2020 19:30:41 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id l71so12535948pge.4 for ; Tue, 22 Sep 2020 10:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version; bh=851N0qVEMFd5TKjHncg9YLB9q3tkhy3CDwVsiryI2ps=; b=LXmlzARPxKO81rHu7e7OcEFEa0xCjXVmvbWIabWMTrOOodm+hUd9OYNBAUmf/yf+zO El1pjZo8FPTKNnGu8W99eH6Iuo9VeJRtrOgC1EnOa/x7tTMKBG7BnSTzWEw2y8p73DN/ 4fPX3tL2ZJOiOAyoNyCwiueUUhb3AsWPawD6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=851N0qVEMFd5TKjHncg9YLB9q3tkhy3CDwVsiryI2ps=; b=EMjgZxSMdOBhfR1lEosv/osys51VjeJXdO5aEjPayp+nmdbyLBPZ4pcVSDSfGLtKUh inlvBJpb9SYiiLPKG1cKqss8qrj1coWrMYxm0YqI/neQ1PArYpX/BzKDl2HW9cNA+Uw+ xkVipPcuL76WXaf2V1w9AQqxXcrgy6a4rljhL2tWzcpdvgMfJ7jgyL2nM3jZNHCuPqiU QK24jC6Uv09llw1THHzTVXdIdDaP37tLPfdSzkhgHOigW+wzB4nEUd5y/aeVxxI+v2b5 KSutNp+B7aNwqugxNPW8JchEz9mf7INaFEY0/X4EXAt5I1b+fdI2T0A5jdqJEMJ10YS4 sQ7g== X-Gm-Message-State: AOAM532mngERpNEgs2sI3K6212EMg94Le6TZcOnivQcFe37r1J7eBScx jfxAyaIeBTcMO1556oa11XiohA== X-Google-Smtp-Source: ABdhPJzDYpoRFrv4TAPFIpSiDJxSdgHZ1ZYccbEybpUn5mWBNdcwNCmo9OzI6RnJm/X8hBihxgiUig== X-Received: by 2002:a63:d251:: with SMTP id t17mr4379268pgi.280.1600795840090; Tue, 22 Sep 2020 10:30:40 -0700 (PDT) Received: from localhost.localdomain ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id t3sm2929484pje.43.2020.09.22.10.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 10:30:39 -0700 (PDT) From: Lance Richardson To: Ajit Khaparde , Somnath Kotur Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 22 Sep 2020 13:30:34 -0400 Message-Id: <20200922173035.285151-1-lance.richardson@broadcom.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] [PATCH 1/2] net/bnxt: fix drop en in rxq get information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Return correct value for rx_drop_en. Add per-queue field to track rx_drop_en configuration. Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") Cc: stable@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 ++--- drivers/net/bnxt/bnxt_rxq.c | 5 +++++ drivers/net/bnxt/bnxt_rxq.h | 4 ++++ 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 05e9a6abbf..61684e0291 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -887,8 +887,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, .wthresh = 0, }, .rx_free_thresh = 32, - /* If no descriptors available, pkts are dropped by default */ - .rx_drop_en = 1, + .rx_drop_en = BNXT_DEFAULT_RX_DROP_EN, }; dev_info->default_txconf = (struct rte_eth_txconf) { @@ -2600,7 +2599,7 @@ bnxt_rxq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id, qinfo->nb_desc = rxq->nb_rx_desc; qinfo->conf.rx_free_thresh = rxq->rx_free_thresh; - qinfo->conf.rx_drop_en = 0; + qinfo->conf.rx_drop_en = rxq->drop_en; qinfo->conf.rx_deferred_start = rxq->rx_deferred_start; } diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 793a47d112..8cc77f7f9e 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -330,6 +330,11 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev, rxq->rx_free_thresh = RTE_MIN(rte_align32pow2(nb_desc) / 4, RTE_BNXT_MAX_RX_BURST); + if (rx_conf->rx_drop_en != BNXT_DEFAULT_RX_DROP_EN) + PMD_DRV_LOG(NOTICE, + "Per-queue config of drop-en is not supported.\n"); + rxq->drop_en = BNXT_DEFAULT_RX_DROP_EN; + PMD_DRV_LOG(DEBUG, "RX Buf MTU %d\n", eth_dev->data->mtu); rc = bnxt_init_rx_ring_struct(rxq, socket_id); diff --git a/drivers/net/bnxt/bnxt_rxq.h b/drivers/net/bnxt/bnxt_rxq.h index fae92ea45c..f70cb04373 100644 --- a/drivers/net/bnxt/bnxt_rxq.h +++ b/drivers/net/bnxt/bnxt_rxq.h @@ -9,6 +9,9 @@ /* Maximum receive burst supported in vector mode. */ #define RTE_BNXT_MAX_RX_BURST 64U +/* Drop by default when receive desc is not available. */ +#define BNXT_DEFAULT_RX_DROP_EN 1 + struct bnxt; struct bnxt_rx_ring_info; struct bnxt_cp_ring_info; @@ -34,6 +37,7 @@ struct bnxt_rx_queue { uint8_t crc_len; /* 0 if CRC stripped, 4 otherwise */ uint8_t rx_deferred_start; /* not in global dev start */ uint8_t rx_started; /* RX queue is started */ + uint8_t drop_en; /* Drop when rx desc not available. */ struct bnxt *bp; int index;