net/bnxt: fix compilation error on Redhat 8
diff mbox series

Message ID 20200918070155.31789-1-thierry.herbelot@6wind.com
State Not Applicable
Delegated to: Ajit Khaparde
Headers show
Series
  • net/bnxt: fix compilation error on Redhat 8
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch warning coding style issues

Commit Message

Thierry Herbelot Sept. 18, 2020, 7:01 a.m. UTC
.../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function ‘bnxt_ulp_destroy_df_rules’:
  .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error:
    comparison is always true due to limited range of data type [-Werror=type-limits]
  for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
                            ^

Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Somnath Kotur Sept. 18, 2020, 7:12 a.m. UTC | #1
On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot
<thierry.herbelot@6wind.com> wrote:
>
>   .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function ‘bnxt_ulp_destroy_df_rules’:
>   .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error:
>     comparison is always true due to limited range of data type [-Werror=type-limits]
>   for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
>                             ^
>
> Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
> Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Cc: Somnath Kotur <somnath.kotur@broadcom.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
>  drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> index 9fb1a028ff66..ff5aed3d74c4 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> @@ -397,7 +397,7 @@ void
>  bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
>  {
>         struct bnxt_ulp_df_rule_info *info;
> -       uint8_t port_id;
> +       uint16_t port_id;
>
>         if (!BNXT_TRUFLOW_EN(bp) ||
>             BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))
> --
> 2.27.0
>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
David Marchand Sept. 18, 2020, 7:31 a.m. UTC | #2
On Fri, Sep 18, 2020 at 9:12 AM Somnath Kotur
<somnath.kotur@broadcom.com> wrote:
>
> On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot
> <thierry.herbelot@6wind.com> wrote:
> >
> >   .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function ‘bnxt_ulp_destroy_df_rules’:
> >   .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error:
> >     comparison is always true due to limited range of data type [-Werror=type-limits]
> >   for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
> >                             ^
> >
> > Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
> > Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Cc: Somnath Kotur <somnath.kotur@broadcom.com>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > ---
> >  drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > index 9fb1a028ff66..ff5aed3d74c4 100644
> > --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > @@ -397,7 +397,7 @@ void
> >  bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
> >  {
> >         struct bnxt_ulp_df_rule_info *info;
> > -       uint8_t port_id;
> > +       uint16_t port_id;
> >
> >         if (!BNXT_TRUFLOW_EN(bp) ||
> >             BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))
> > --
> > 2.27.0
> >
> Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
>

This patch rang a bell.
There is the exact same patch proposed by Xia with a comment, so I
guess Xia is still working on it?
https://patchwork.dpdk.org/patch/75177/#117201
Ajit Khaparde Sept. 18, 2020, 4:16 p.m. UTC | #3
::snip::
> >
>
> This patch rang a bell.
> There is the exact same patch proposed by Xia with a comment, so I
> guess Xia is still working on it?
> https://patchwork.dpdk.org/patch/75177/#117201
Xia,
Will you submit the changes that Thomas asked for?
Otherwise I will apply the bnxt patch and you can work on the rest.

Thanks
Ajit
Xia, Chenbo Sept. 20, 2020, 3:26 p.m. UTC | #4
Hi, David & Ajit

Yes, I will submit a patch to change all eth port id to uint16_t
this week as I promised. Is this ok for you?

Thanks,
Chenbo

> -----Original Message-----
> From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Sent: Saturday, September 19, 2020 12:16 AM
> To: David Marchand <david.marchand@redhat.com>
> Cc: Somnath Kotur <somnath.kotur@broadcom.com>; Thierry Herbelot
> <thierry.herbelot@6wind.com>; Xia, Chenbo <chenbo.xia@intel.com>; dev
> <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat
> 8
> 
> ::snip::
> > >
> >
> > This patch rang a bell.
> > There is the exact same patch proposed by Xia with a comment, so I
> > guess Xia is still working on it?
> > https://patchwork.dpdk.org/patch/75177/#117201
> Xia,
> Will you submit the changes that Thomas asked for?
> Otherwise I will apply the bnxt patch and you can work on the rest.
> 
> Thanks
> Ajit

Patch
diff mbox series

diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
index 9fb1a028ff66..ff5aed3d74c4 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
@@ -397,7 +397,7 @@  void
 bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
 {
 	struct bnxt_ulp_df_rule_info *info;
-	uint8_t port_id;
+	uint16_t port_id;
 
 	if (!BNXT_TRUFLOW_EN(bp) ||
 	    BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))