From patchwork Thu Sep 17 05:30:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 77967 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB446A04B6; Thu, 17 Sep 2020 07:31:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3925C1D55E; Thu, 17 Sep 2020 07:31:04 +0200 (CEST) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id DB4B01D51E for ; Thu, 17 Sep 2020 07:30:58 +0200 (CEST) Received: by mail-lf1-f67.google.com with SMTP id y11so774217lfl.5 for ; Wed, 16 Sep 2020 22:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EeYkbuFu1O/PoD2lnDYRTbHm/yzNz/T4151RCGMT2sw=; b=GSYC3XalsEO4WwmMs6tpIiT+yHPQPnGz9RSeJMMy18mBDHN6IJ4kso8REEGyvObsas iQY+VMrxDrGp4eXBnzNNVv9/LnGKMZJm+/bTeD3cGWFm1WiTP8YAyNZD7Nlxmzpf5ob3 Wgv7DapiTGQyx69YfLbJ+WBsJXq4otfLfWgRqHQf7HkIVPHUm0LF8gj/2Q+XDHMRZ3cQ MXxxyjlNijxr0JsNtphKyDR/mL92XIaFpRVCH6GIXZoVEEvjh1cL1w+193ZnqwaM+kYi WXnlQpt1Qn2gVxFhQAJ3+MaEsSnh3TSCAFT7gtuR4XY2NZFN0gm5O2cNagrVoWlc+stC iUzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EeYkbuFu1O/PoD2lnDYRTbHm/yzNz/T4151RCGMT2sw=; b=aVBSel7sRDTM5JXZMu/HYSn22hniL3ndPX1/K3eLFwej2D7+2kgyvEbz9jN0Omvmxy Pa1R49fmApiZMnD7sdNnx1UZSzHKp5CSXMLeTknobPR+eWijSc4Ru2WjOfx/q4IfMwXl daC3cSSXq8WtzWD+Swh1uUKlKRJ675ZBkmTuj8az99IVjPju/HKQgYjyD2e0JldyusUc Aj9UEkEHz/ooYlG1n2aFAp7Qa7MyCnpEa+TqyoUTYtBZ1lFTBn8falsqDh+dmmwkl0Wu KYTQixeh5p4/Eji8HxHFUs6XQ4K01HY9P8pdncBMTb3ONiMhzgxah0ECxxbbotCpo92f mFOw== X-Gm-Message-State: AOAM530lZ1i2Tbb9wUGtrfrP/rVfJNJtRPgvk8t5FGxuwgyGvKGsGF6A a55INo4wCLEwngdJojrkq30S6ymRsOlLWqNV X-Google-Smtp-Source: ABdhPJwib8nrQ/3x0UPSvYhdw4PfRvSI4s2UCkFJvJobw7MzPDvTetLjdEOXrIXXkz68kj2vcA7cyg== X-Received: by 2002:a19:dd5:: with SMTP id 204mr8240911lfn.579.1600320658185; Wed, 16 Sep 2020 22:30:58 -0700 (PDT) Received: from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 22:30:57 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk , Marcin Wojtas , Evgeny Schemeilin Date: Thu, 17 Sep 2020 07:30:22 +0200 Message-Id: <20200917053035.1889989-8-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200917053035.1889989-1-mk@semihalf.com> References: <20200917053035.1889989-1-mk@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 07/20] net/ena/base: rework setup of accelerated LLQ mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The purpose of this change is general code simplification and type safety improvement for the logical values. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 21 ++++++++++----------- drivers/net/ena/base/ena_eth_com.h | 2 +- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c index f660c47551..b21c1f8d83 100644 --- a/drivers/net/ena/base/ena_com.c +++ b/drivers/net/ena/base/ena_com.c @@ -610,13 +610,9 @@ static int ena_com_set_llq(struct ena_com_dev *ena_dev) cmd.u.llq.desc_num_before_header_enabled = llq_info->descs_num_before_header; cmd.u.llq.descriptors_stride_ctrl_enabled = llq_info->desc_stride_ctrl; - if (llq_info->disable_meta_caching) - cmd.u.llq.accel_mode.u.set.enabled_flags |= - BIT(ENA_ADMIN_DISABLE_META_CACHING); - - if (llq_info->max_entries_in_tx_burst) - cmd.u.llq.accel_mode.u.set.enabled_flags |= - BIT(ENA_ADMIN_LIMIT_TX_BURST); + cmd.u.llq.accel_mode.u.set.enabled_flags = + BIT(ENA_ADMIN_DISABLE_META_CACHING) | + BIT(ENA_ADMIN_LIMIT_TX_BURST); ret = ena_com_execute_admin_command(admin_queue, (struct ena_admin_aq_entry *)&cmd, @@ -635,6 +631,7 @@ static int ena_com_config_llq_info(struct ena_com_dev *ena_dev, struct ena_llq_configurations *llq_default_cfg) { struct ena_com_llq_info *llq_info = &ena_dev->llq_info; + struct ena_admin_accel_mode_get llq_accel_mode_get; u16 supported_feat; int rc; @@ -738,13 +735,15 @@ static int ena_com_config_llq_info(struct ena_com_dev *ena_dev, llq_info->descs_num_before_header); } /* Check for accelerated queue supported */ + llq_accel_mode_get = llq_features->accel_mode.u.get; + llq_info->disable_meta_caching = - llq_features->accel_mode.u.get.supported_flags & - BIT(ENA_ADMIN_DISABLE_META_CACHING); + !!(llq_accel_mode_get.supported_flags & + BIT(ENA_ADMIN_DISABLE_META_CACHING)); - if (llq_features->accel_mode.u.get.supported_flags & BIT(ENA_ADMIN_LIMIT_TX_BURST)) + if (llq_accel_mode_get.supported_flags & BIT(ENA_ADMIN_LIMIT_TX_BURST)) llq_info->max_entries_in_tx_burst = - llq_features->accel_mode.u.get.max_tx_burst_size / + llq_accel_mode_get.max_tx_burst_size / llq_default_cfg->llq_ring_entry_size_value; rc = ena_com_set_llq(ena_dev); diff --git a/drivers/net/ena/base/ena_eth_com.h b/drivers/net/ena/base/ena_eth_com.h index 3d66237b8d..7dda16cd9f 100644 --- a/drivers/net/ena/base/ena_eth_com.h +++ b/drivers/net/ena/base/ena_eth_com.h @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright (c) 2015-2019 Amazon.com, Inc. or its affiliates. + * Copyright (c) 2015-2020 Amazon.com, Inc. or its affiliates. * All rights reserved. */