[v8,1/3] ethdev: add level support for RSS offload types
diff mbox series

Message ID 20200917020735.2195069-1-kirankumark@marvell.com
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series
  • [v8,1/3] ethdev: add level support for RSS offload types
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Kiran Kumar Kokkilagadda Sept. 17, 2020, 2:07 a.m. UTC
From: Kiran Kumar K <kirankumark@marvell.com>

This patch reserves 2 bits as input selection to select Inner and
outer encapsulation level for RSS computation. It is combined with existing
ETH_RSS_* to choose Inner or outer layers.
This functionality already exists in rte_flow through level parameter in
RSS action configuration rte_flow_action_rss.

Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
---
V8 Changes:
* Re-worked the level parameters. Added as PMD_DEFAULT, LEVEL_OUTERMOST,
LEVEL_INNERMOST
 lib/librte_ethdev/rte_ethdev.h | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

--
2.25.1

Comments

Andrew Rybchenko Sept. 17, 2020, 9:36 a.m. UTC | #1
On 9/17/20 5:07 AM, kirankumark@marvell.com wrote:
> From: Kiran Kumar K <kirankumark@marvell.com>
> 
> This patch reserves 2 bits as input selection to select Inner and
> outer encapsulation level for RSS computation. It is combined with existing
> ETH_RSS_* to choose Inner or outer layers.
> This functionality already exists in rte_flow through level parameter in
> RSS action configuration rte_flow_action_rss.
> 
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Ajit Khaparde Sept. 17, 2020, 6:56 p.m. UTC | #2
On Thu, Sep 17, 2020 at 2:36 AM Andrew Rybchenko
<arybchenko@solarflare.com> wrote:
>
> On 9/17/20 5:07 AM, kirankumark@marvell.com wrote:
> > From: Kiran Kumar K <kirankumark@marvell.com>
> >
> > This patch reserves 2 bits as input selection to select Inner and
> > outer encapsulation level for RSS computation. It is combined with existing
> > ETH_RSS_* to choose Inner or outer layers.
> > This functionality already exists in rte_flow through level parameter in
> > RSS action configuration rte_flow_action_rss.
> >
> > Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Ferruh Yigit Sept. 18, 2020, 11:40 a.m. UTC | #3
On 9/17/2020 7:56 PM, Ajit Khaparde wrote:
> On Thu, Sep 17, 2020 at 2:36 AM Andrew Rybchenko
> <arybchenko@solarflare.com> wrote:
>>
>> On 9/17/20 5:07 AM, kirankumark@marvell.com wrote:
>>> From: Kiran Kumar K <kirankumark@marvell.com>
>>>
>>> This patch reserves 2 bits as input selection to select Inner and
>>> outer encapsulation level for RSS computation. It is combined with existing
>>> ETH_RSS_* to choose Inner or outer layers.
>>> This functionality already exists in rte_flow through level parameter in
>>> RSS action configuration rte_flow_action_rss.
>>>
>>> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
>>
>> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 

Series applied to dpdk-next-net/main, thanks.

Patch
diff mbox series

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 70295d7ab..869748474 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -552,6 +552,33 @@  struct rte_eth_rss_conf {
 #define RTE_ETH_RSS_L3_PRE64	   (1ULL << 53)
 #define RTE_ETH_RSS_L3_PRE96	   (1ULL << 52)

+/*
+ * We use the following macros to combine with the above layers to choose
+ * inner and outer layers or both for RSS computation.
+ * bit 50 and 51 are reserved for this.
+ */
+
+/** level 0, requests the default behavior. Depending on the packet
+ * type, it can mean outermost, innermost, anything in between or even no RSS.
+ * It basically stands for the innermost encapsulation level RSS
+ * can be performed on according to PMD and device capabilities.
+ */
+#define ETH_RSS_LEVEL_PMD_DEFAULT       (0ULL << 50)
+
+/** level 1,  requests RSS to be performed on the outermost packet
+ * encapsulation level.
+ */
+#define ETH_RSS_LEVEL_OUTERMOST         (1ULL << 50)
+
+/** level 2,  requests RSS to be performed on the
+ * specified inner packet encapsulation level, from outermost to
+ * innermost (lower to higher values).
+ */
+#define ETH_RSS_LEVEL_INNERMOST         (2ULL << 50)
+#define ETH_RSS_LEVEL_MASK              (3ULL << 50)
+
+#define ETH_RSS_LEVEL(rss_hf) ((rss_hf & ETH_RSS_LEVEL_MASK) >> 50)
+
 /**
  * For input set change of hash filter, if SRC_ONLY and DST_ONLY of
  * the same level are used simultaneously, it is the same case as