From patchwork Wed Sep 16 04:28:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 77840 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7941FA04C7; Wed, 16 Sep 2020 06:30:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 670931C1BD; Wed, 16 Sep 2020 06:29:20 +0200 (CEST) Received: from mail-pj1-f100.google.com (mail-pj1-f100.google.com [209.85.216.100]) by dpdk.org (Postfix) with ESMTP id ED9401C19F for ; Wed, 16 Sep 2020 06:29:10 +0200 (CEST) Received: by mail-pj1-f100.google.com with SMTP id s14so896896pju.1 for ; Tue, 15 Sep 2020 21:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xyEp5opwXj5494eRK0j4QtDCKHy2TG4iZSlhSkjB9m0=; b=G1q9rmjb7lAtu09ZljiQiYUdBxgRTNdZU4cJzLP1ph7/DGVCA9Di5P3EhmaeiA6KBr TAxnd2V5MkFgtd1brenLQBlmsyhltqkdNLsAD7OjCm16cMetsXLGw6/iCkfmKKN3Wg/w WXlQ5qANorNpbBW6/Rcq3eVVsNrAbDrXTSHS8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xyEp5opwXj5494eRK0j4QtDCKHy2TG4iZSlhSkjB9m0=; b=QeVV0b9Mgatwd0vAXWL/5OwbqV3mhVPku+NqfvYtDIOSZo/5ooENdDdRn178RoIONk 1K1n2lNTfdzW3H9Yqk19HIqtAueX8xu5iiRotiS7VVWuLSd0hHhNAF32bU8NPsVaLzZu uFNvheCtfbPIwy9hXRvaFH5JbOVZn9RpvvRIdBG6glPVM7XzAwA9g4Ttp9Gwh1qjTOZU xN6n9dLJahEK7naLaRW5I8OpJIS0f3wjmrpOjgWRxN3gkGj9WPm/xCLdr5j7QP4761tR TQxh5i8K18A8jf4rxtHp0dLOFEwMuODIoMAnFJBQdbEuuCRwzyIZ7YXtBpPSNb6IATyy ZBlg== X-Gm-Message-State: AOAM530UfDAxniHgzai/X0k3IElNPTt9nMbSpUZXX9ApOrdvuSLvEay3 5wk6UK3aVwecI0kj7rDjfHxp8O+fbVsjev5nCKi8nc502OvU1p9sebt8GoKJxQc/31x/E/wtlA1 WbLXZtJ2EFrxM1AX25khB6JH1F4MzqmEuGpr0SVv3eoJD/Va6BciJ1SoHpaXnW+r6KDs16ZmPWt P7SQ== X-Google-Smtp-Source: ABdhPJxNQe+8vagoVDAApccxXdZ1CNA8srPLT+VrHcxVb48MnFtJs//jkZ9cufYB4P6/QphHfcXXt51rp15l X-Received: by 2002:a17:902:988f:b029:d0:4c09:c1 with SMTP id s15-20020a170902988fb02900d04c0900c1mr21739687plp.3.1600230549976; Tue, 15 Sep 2020 21:29:09 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id hk6sm132636pjb.6.2020.09.15.21.29.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2020 21:29:09 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: Somnath Kotur , Venkat Duvvuru Date: Tue, 15 Sep 2020 21:28:37 -0700 Message-Id: <20200916042851.32914-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200916042851.32914-1-ajit.khaparde@broadcom.com> References: <20200911015603.88359-1-ajit.khaparde@broadcom.com> <20200916042851.32914-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 11/25] net/bnxt: fix crash in VFR queue select X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Somnath Kotur Instead of bounds checking against max possible rings while selecting queue index for the VF representor, do it against the number of rings configured. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Somnath Kotur Reviewed-by: Venkat Duvvuru --- drivers/net/bnxt/bnxt_reps.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c index b975d5af0..ef5bd0665 100644 --- a/drivers/net/bnxt/bnxt_reps.c +++ b/drivers/net/bnxt/bnxt_reps.c @@ -45,9 +45,12 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf) vfr_eth_dev = &rte_eth_devices[port_id]; vfr_bp = vfr_eth_dev->data->dev_private; - /* If rxq_id happens to be > max rep_queue, use rxq0 */ - que = queue_id < BNXT_MAX_VF_REP_RINGS ? queue_id : 0; + /* If rxq_id happens to be > nr_rings, use ring 0 */ + que = queue_id < vfr_bp->rx_nr_rings ? queue_id : 0; rep_rxq = vfr_bp->rx_queues[que]; + /* Ideally should not happen now, paranoid check */ + if (!rep_rxq) + return 1; rep_rxr = rep_rxq->rx_ring; mask = rep_rxr->rx_ring_struct->ring_mask;