From patchwork Wed Sep 16 04:28:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 77834 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7906BA04C7; Wed, 16 Sep 2020 06:29:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C1491C191; Wed, 16 Sep 2020 06:29:08 +0200 (CEST) Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) by dpdk.org (Postfix) with ESMTP id 1D1711C190 for ; Wed, 16 Sep 2020 06:29:07 +0200 (CEST) Received: by mail-pl1-f226.google.com with SMTP id y6so2494843plt.9 for ; Tue, 15 Sep 2020 21:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DDAglMDMJs5oGJyg6MF/+Gs41Y095klJmMi+gJgOuE4=; b=RKhmFkvEhYgK2sbZ5bCgOW7fboVrzri4haWvhHQ1g7ihgcMGWBxPWa2sNl6zc3LUur Ts1w8Loe1JLXHEjrnDYP7cvgy4u1pmam+Fv5zsLob/Q/GhFnxfVXke+TWgv7T+IBgL2o pC9FAxXIaC1TB4MJiddRv71gkLHKHYcNoQRxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DDAglMDMJs5oGJyg6MF/+Gs41Y095klJmMi+gJgOuE4=; b=aHasvHD6l227EIkW38AFOmpi285Mgzai0A3FtMsvLSl3m13p6z/ujNNXMnTDmIXQXR faPTSypYvY1HN8oSIj6OG39IdJ16UWMhOyThbHUmdZGyjRaOs8CXbB7bDrNmWqu1R1RV kyUMd6KpGNKfBE6DON7p6/4NN0zL29BXSMl4X++udWpjxhnmD+D4pGvLbseTmu2VRtfD U23fWiF4rzI9YDm5MCb79iR9YVYeCMbqeAX255eTUU2IonfLP2CH4gS9nUO8wyVxA3RH IwCec7aM/Nc2JY6WfZaIuTDplSSMlYARWR3Ff7LIyLQVehuvQCkWshyLW9SEFtzJTCLA QdEw== X-Gm-Message-State: AOAM531T8kXCffYsJkFuyS7P+sjD+V6oPPWXIP9mxLWAPHBckl2NSFIw 3eiHZ1+wRm7X911RMAUSLIL3fGF4/+nZrFXIaTBPwUfahhj2xFXZILECxn3kHki/DmovvkgmiQD OdBojYkAZMQImk64d+mGoN+0Y9jVNQ7GAsEMfRYnvKNofMeSQUQhbGXOV2ECtI1nu7n1uPG3W2p /3CA== X-Google-Smtp-Source: ABdhPJw4f3MnfI0sgGHTKHklNNux87vGiAr50ZW5c7kwX8FDCCxN0O8TxCI6CCak4Pk0IvHCr7MRx4SXAtNq X-Received: by 2002:a17:90a:9415:: with SMTP id r21mr2310882pjo.180.1600230546100; Tue, 15 Sep 2020 21:29:06 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id hk6sm132636pjb.6.2020.09.15.21.29.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2020 21:29:06 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: Mike Baucom Date: Tue, 15 Sep 2020 21:28:32 -0700 Message-Id: <20200916042851.32914-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200916042851.32914-1-ajit.khaparde@broadcom.com> References: <20200911015603.88359-1-ajit.khaparde@broadcom.com> <20200916042851.32914-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 06/25] net/bnxt: free the EM index on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Mike Baucom When a Exact Match entry fails insertion, the allocated index needs to be pushed back to the allocation stack. This patch takes care of that. Signed-off-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_em_internal.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf_core/tf_em_internal.c b/drivers/net/bnxt/tf_core/tf_em_internal.c index 462d0fa76..c95515b1b 100644 --- a/drivers/net/bnxt/tf_core/tf_em_internal.c +++ b/drivers/net/bnxt/tf_core/tf_em_internal.c @@ -175,8 +175,11 @@ tf_em_insert_int_entry(struct tf *tfp, &rptr_index, &rptr_entry, &num_of_entries); - if (rc) + if (rc) { + /* Free the allocated index before returning */ + stack_push(pool, index); return -1; + } PMD_DRV_LOG (DEBUG,