From patchwork Fri Sep 11 07:59:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sachin Saxena (OSS)" X-Patchwork-Id: 77345 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94F53A04B5; Fri, 11 Sep 2020 09:59:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 690741C0CD; Fri, 11 Sep 2020 09:59:30 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70079.outbound.protection.outlook.com [40.107.7.79]) by dpdk.org (Postfix) with ESMTP id 05CEA1C0CA; Fri, 11 Sep 2020 09:59:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJR/IiZM3w/xMNUOmu2tbyM4o+m9U7mI6DiLFYZfunKkHWLQHwr8TWstFMKX4XTwMQD0vEk33HReOzs3Ysqp4wEVxnKaN8HZ1x14q+KZvmLYIHQRqY3wCWMeI+jiNOWo1Ut3qIUpzkj5Uz2W8j0GqoCf22rLXgvTq8rIb5IELiDbqQXvrZY9bDPeizEkKqqQHYFXgj3CT9wMGa+hR7ouIeaAJdj2U0BclV407JsEt/iGp+x2BY2/DlalW8bEk6MNfccpFfe/0epQDZQARlBatfaIjyo4tkLeZgXkz8TwDObbR+WoD1rlvhpr14/WFEqgwZiWbhgZw9t5lrransJsUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvWCyDpz9zTtQBdb+PVRepHgeFeC4MjPNLnHm7JFm9o=; b=NuYd4N3YRxCpNpIOXXdMk2D8wvk/PTDrPWYfHKcU61/OPuygnUJ0ZsnVWNQ1xUbhyi+2y17osnzBkGoqkReI82lvFhDfPs2Is007vUuZpyLaUEkU6Ozl7FPFyRMyGIjvd6FpVAU3YoyqJCgvtcrEaZ1U7SIM4os2HgvV+HD6++BFKQibcsyi4Ya5i0aQDClsM/KNE217T50w8z9mYYYGm0ryALWyxV1XbHtbGg2ykWGbtmwf2geH8lBahPiB+G6cF21ExbKI7ziSs7yRFTT211UGsAYtG9vXSO5Wf2IFk4Sv7s7EKanJmeajrcxlnn9AQYOMs7gIhrIQNz23n1L5Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EvWCyDpz9zTtQBdb+PVRepHgeFeC4MjPNLnHm7JFm9o=; b=MGVKHjWXbQ4JVwQ5jHzw8fzIntRT3Qlk8fDHI6CiCr8q52mxU10g7aCAbAtKNUaYN7qAJujuC/f3jpmdkFGnGz9TqGdTt7z7Hat1xwP0/C2dGeiR31u44P/fxxuCPtAxgzvUOgAvxvsYWoQFvl+gY9HtnkmIcvaWn/WyXhbgL+c= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28) by VI1PR04MB6094.eurprd04.prod.outlook.com (2603:10a6:803:f4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.17; Fri, 11 Sep 2020 07:59:26 +0000 Received: from VI1PR04MB5837.eurprd04.prod.outlook.com ([fe80::cc01:9fe2:2544:8a4b]) by VI1PR04MB5837.eurprd04.prod.outlook.com ([fe80::cc01:9fe2:2544:8a4b%7]) with mapi id 15.20.3348.019; Fri, 11 Sep 2020 07:59:26 +0000 From: "Sachin Saxena (OSS)" To: dev@dpdk.org, ferruh.yigit@intel.com Cc: stable@dpdk.org Date: Fri, 11 Sep 2020 13:29:04 +0530 Message-Id: <20200911075911.3214-2-sachin.saxena@oss.nxp.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911075911.3214-1-sachin.saxena@oss.nxp.com> References: <20200911075911.3214-1-sachin.saxena@oss.nxp.com> X-ClientProxiedBy: SG2PR06CA0136.apcprd06.prod.outlook.com (2603:1096:1:1f::14) To VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from lsv03161.swis.in-blr01.nxp.com (14.142.151.118) by SG2PR06CA0136.apcprd06.prod.outlook.com (2603:1096:1:1f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3370.16 via Frontend Transport; Fri, 11 Sep 2020 07:59:25 +0000 X-Mailer: git-send-email 2.28.0 X-Originating-IP: [14.142.151.118] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9d365387-12d7-47ab-6a17-08d856289a71 X-MS-TrafficTypeDiagnostic: VI1PR04MB6094: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:370; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X/a7SgOxeHtIIwzuFhtp9EsM5XZXH7ui44piLOVkDte0GVU1Z3O3mHBE4vUFXs2F2L1Qyb6Myuf1kkfM04TkPujY9k5eezePKlJdVcJafhXVx+mpILuL1KXyBkz2Wyamr5mXmoAiTajoXsmwcIheWTab5iWNn3G0q7muw/s1ut0sJV96Bk9sffOLL6LnH6iYm/py+yvG7hAtAYRysttsVunhG/XLO+ucrfUgnNllxV4bsBvur0woDbbCtJI/bCdZQCrzoNg71KEX9pP97gEDolYYNqRBAqizOsiQylxw2i54Zbp/FcvPI6c+p5GMKGhrPat3foWyhw75S7pJ5eSF2ld3hNtNRw6g+V6RpqWtHNnB10XL827e4hVTwE+u1+El X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5837.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(346002)(396003)(366004)(478600001)(52116002)(2616005)(55236004)(86362001)(6486002)(6506007)(8676002)(316002)(16526019)(8936002)(26005)(4326008)(186003)(6512007)(2906002)(956004)(5660300002)(66556008)(66476007)(1076003)(66946007)(83380400001)(6666004)(1006002)(110426005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: mG2FqdbR4KIY/5nYWO+26VGAOPG0lAw01rDj3FLJWuJH6xmMgC1lHLHJcqk1s9z+6h3fqtUaWLeziPPxvi7XnZOoAR/3NLmqoMnMf3lxFRXEsWJ939WaeF3+svXAzuLdsDqYyjS27x1UH8Y0arjLTT/HfULs1Bf9JfpBU7p3hQG0tNQnvWGqATnq/S8Xw5JHrTgnQEtqmKD8OAG19zGB+4lMrhxcjNXZvffr+h1BD4lWFro6wMZCc5DPxNX9YFXYj7sK5qMPc1Hs2xcuwof8JUR6ar/GSujVAB2LPhNazj8F4CeCRWNg8oU2XQhyfVlUWMIF9AT5ITQCDK/ywgp7JKIm1QlZw8ah4nB8PtDBnfqRzaBY1Wl7pUII0NUWG0xUaqL6r053AhKeTsy6zVeCCcyVD4w4IKrNY6+QZtsTmlHU5gZtshyk/BP04qmo1tdczwarMiLp/lqbfkVuEvMhOGjozeqNfOLkKOckd6TNJXODKXR40/0aV47JC5cvn4N1er9pUk05cGFOM5MvRBHLOcqZGjzcJ/PHNtuZgRztsN/wj1D27RoTom9j6LZKFV83pMCe9uV5xTTGVIbTaWDrfeL+BVLyPb4XQea7cZHKqrhRSFwT63O4+q4RyfnmH5PYfH8vTuKO2i9qtRnBer7y3A== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d365387-12d7-47ab-6a17-08d856289a71 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5837.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2020 07:59:26.7267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 53wN13keS9RhFa53/aGT44SnxT8g9kanPosCkdbny9nJBthvichV/ZffBQxcVS1wf41RrsNE2nSDfjJY6w9REw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6094 Subject: [dpdk-dev] [PATCH v1 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index to consumer index") Cc: stable@dpdk.org Signed-off-by: Youri Querry Signed-off-by: Rohit Raj --- drivers/bus/fslmc/qbman/qbman_portal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index 0a2af7be4..77c9d508c 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -1201,6 +1201,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask)); memcpy(&p[1], &cl[1], 28); memcpy(&p[8], &fd[i], sizeof(*fd)); + p[0] = cl[0] | s->eqcr.pi_vb; + if (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) { struct qbman_eq_desc *d = (struct qbman_eq_desc *)p; @@ -1208,7 +1210,6 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, ((flags[i]) & QBMAN_EQCR_DCA_IDXMASK); } eqcr_pi++; - p[0] = cl[0] | s->eqcr.pi_vb; if (!(eqcr_pi & half_mask)) s->eqcr.pi_vb ^= QB_VALID_BIT;