From patchwork Fri Sep 11 01:55:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 77269 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55D20A04B5; Fri, 11 Sep 2020 03:57:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68D701C125; Fri, 11 Sep 2020 03:56:49 +0200 (CEST) Received: from mail-pf1-f227.google.com (mail-pf1-f227.google.com [209.85.210.227]) by dpdk.org (Postfix) with ESMTP id D28481C116 for ; Fri, 11 Sep 2020 03:56:46 +0200 (CEST) Received: by mail-pf1-f227.google.com with SMTP id d6so6016941pfn.9 for ; Thu, 10 Sep 2020 18:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AWyMtL7TNvU6BU1Ikpbrd9HQD1pcW/fQekMp3Ob76dY=; b=YJpfx91i4WX2NXgoUMHLM1IqKFpq4CVhCmDtKJDG8Dxqu5rALFh2UWdPXUidwkEiJX Sxa1M4Wdqmh9iYgP3Jap36iJLJV8DeB5FDIUUM3WXZhWHYM9ofGtoBbB+9zlrYYdiAdb J8q0DbauTKLmz2Gvc4V/uW2EDiYw35kLMxSNg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AWyMtL7TNvU6BU1Ikpbrd9HQD1pcW/fQekMp3Ob76dY=; b=a6kvIuOo8lFGU4i3r+uIsiIK27EWWthfMs3LJE8wVqzxQzeieFCGA6+fyvQwv0oKwL TzuYJ/9rCAiIz+81OjopxSuDZdkWzb/edXm7TnMZAoXtY+HD7sNFCuD865w2zChrYFV7 nS7V8xgmrX6XDwBVkzyGpkz2f/juJmOskcfqIqcatRlceYwwrLZ0wIjPISd9BVK06czD xYCtJsJNSphzIVr4oREvvmeXjjSn+Z+DmQKBN/+ycfCjhu1RRfnKdD42eOHhunOqEcYJ dx8jXJUvrpiIA06sYsFqYtH8vbxYMivzIUfhM7Ew/aBJWadiA1ItHDLplRYjjocZINVG SLPw== X-Gm-Message-State: AOAM532MY1i2j8AcbyJPKajMcw5odBiJ3b+kpgvFLzLXyngW3vzJhTtY Umx1N/NbzWanQ3aLCkAcNWulc5eMU8ctvS/072egq7ZTeDwbHDHPLfSo9l/qw7G76S/Q6Fw0DaA Aoa5Gqa5kOVj0mdYOyUGXfnvTX2u5XBOVYC03iy5jtoWYI+Kz7L79JFs6qCnYYOTucEaA0uVJU8 ePjQ== X-Google-Smtp-Source: ABdhPJzQb+PaLQICfZEqzWmvw68YlnxcIjUnLpYg/lA2OBe9UZLQR6f0e+8fVAub8KOfYq8XWcVALfgXhpUP X-Received: by 2002:a17:902:8c89:: with SMTP id t9mr8240657plo.66.1599789405762; Thu, 10 Sep 2020 18:56:45 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id cl6sm80986pjb.15.2020.09.10.18.56.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2020 18:56:45 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: Shahaji Bhosle , Mike Baucom Date: Thu, 10 Sep 2020 18:55:45 -0700 Message-Id: <20200911015603.88359-8-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200911015603.88359-1-ajit.khaparde@broadcom.com> References: <20200911015603.88359-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 07/25] net/bnxt: add a null ptr check for the resource manager X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shahaji Bhosle Verify the resource manager exists prior to using Signed-off-by: Shahaji Bhosle Reviewed-by: Mike Baucom --- drivers/net/bnxt/tf_core/tf_rm.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/bnxt/tf_core/tf_rm.c b/drivers/net/bnxt/tf_core/tf_rm.c index 9aec954db..66a33583b 100644 --- a/drivers/net/bnxt/tf_core/tf_rm.c +++ b/drivers/net/bnxt/tf_core/tf_rm.c @@ -706,6 +706,8 @@ tf_rm_allocate(struct tf_rm_allocate_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ @@ -772,6 +774,8 @@ tf_rm_free(struct tf_rm_free_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ @@ -817,6 +821,8 @@ tf_rm_is_allocated(struct tf_rm_is_allocated_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ @@ -860,6 +866,8 @@ tf_rm_get_info(struct tf_rm_get_alloc_info_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by HCAPI */ @@ -883,6 +891,8 @@ tf_rm_get_hcapi_type(struct tf_rm_get_hcapi_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by HCAPI */ @@ -905,6 +915,8 @@ tf_rm_get_inuse_count(struct tf_rm_get_inuse_count_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */ @@ -937,6 +949,8 @@ tf_rm_check_indexes_in_range(struct tf_rm_check_indexes_in_range_parms *parms) TF_CHECK_PARMS2(parms, parms->rm_db); rm_db = (struct tf_rm_new_db *)parms->rm_db; + if (!rm_db->db) + return -EINVAL; cfg_type = rm_db->db[parms->db_index].cfg_type; /* Bail out if not controlled by RM */