From patchwork Fri Sep 11 01:55:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 77265 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F358A04B5; Fri, 11 Sep 2020 03:56:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68C821C0D2; Fri, 11 Sep 2020 03:56:27 +0200 (CEST) Received: from mail-pf1-f225.google.com (mail-pf1-f225.google.com [209.85.210.225]) by dpdk.org (Postfix) with ESMTP id C33A21C0D2 for ; Fri, 11 Sep 2020 03:56:26 +0200 (CEST) Received: by mail-pf1-f225.google.com with SMTP id w7so6037217pfi.4 for ; Thu, 10 Sep 2020 18:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8t8zTeBf1dASHOewBo0WI+iPVU3Bw/1RS2TGivAJXQg=; b=SRPNmWaXYF+Mix13xZxrPoGi5C2LrAtAb7mTddzP5Lf/T8c8fApFhHa2IijInzczF5 tn0D/Eq6kf3agxhcW6uGhHX6M0XgdSow7POzd/SxY8Pcx7foh2jEKLGmKjBB4WpFl6IN VNd4mpsrFra14es8UW+4S6Ye5QOQmG4IUuYmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8t8zTeBf1dASHOewBo0WI+iPVU3Bw/1RS2TGivAJXQg=; b=Sb23BUHKx7DYLijf8bJgEczmwt8Pa/rDUkYDcWUfTy0SH+/1ZLvH/JEFh3Nv/yCRJB Qle2xbFs2pW/pQ3ZLiEyIhDA27zfXkfggqtdEqbn1vdO0UWh0vpkYkAVIVnZGUG5c5xE 7Le0qXQ5uGoIJJBr/EW1O5rEy7tgkb6Jsyy/Lt9i5mrOvQ+CwMbpDyEXWaCTq9pWebVB dyR/pd0dMvReqvl0PLY8P2TylPz5k+t46wmv1eucgcYP0DNoWD9InXQ+A1bkp3N4pS4J F2eF5plds54DcJ/UVXJ7r/giU4RTeLGp/MFN/LhwI0+RxdqCwZkgeDd5SXOnmP2uLLQb LchA== X-Gm-Message-State: AOAM5324+z1y2Td1FPYzPZullGUj+uVLqv+RzP9sKlPe+VeFVQCncMl1 MyR3+jandMvCsGdCpsMmr9MrnVcqSApYL22D5fdEZu9u/IW2BDOqNZGlfLn2Yrexb5wjc1uZ3wE Nw82D7PTEX8TWYK7YYlFuUQn/fx7/nyAgpbbqPGmhHuZ2JkWXf0ORT8+uZIXw8cIctgI+LvV5C1 mQyg== X-Google-Smtp-Source: ABdhPJwU2z2crojiPNb2mP2hzpvp81IIq5/jGrxzcUjWhl/lPiL65Ndoh+zA0s/WtpWK8RHSn2FFVxSuXh5X X-Received: by 2002:a63:c343:: with SMTP id e3mr6363141pgd.288.1599789385674; Thu, 10 Sep 2020 18:56:25 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id cl6sm80986pjb.15.2020.09.10.18.56.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2020 18:56:25 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , Mike Baucom Date: Thu, 10 Sep 2020 18:55:41 -0700 Message-Id: <20200911015603.88359-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200911015603.88359-1-ajit.khaparde@broadcom.com> References: <20200911015603.88359-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 03/25] net/bnxt: reject offload flows with invalid MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kishore Padmanabha Reject offload flows that have broadcast or multicast ethernet addresses. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c index fcb7c4430..ed95cf60f 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c @@ -603,6 +603,19 @@ ulp_rte_l2_proto_type_update(struct ulp_rte_parser_params *param, } } +/* Internal Function to indentify broadcast or multicast packets */ +static int32_t +ulp_rte_parser_is_bcmc_addr(const struct rte_ether_addr *eth_addr) +{ + if (rte_is_multicast_ether_addr(eth_addr) || + rte_is_broadcast_ether_addr(eth_addr)) { + BNXT_TF_DBG(DEBUG, + "No support for bcast or mcast addr offload\n"); + return 1; + } + return 0; +} + /* Function to handle the parsing of RTE Flow item Ethernet Header. */ int32_t ulp_rte_eth_hdr_handler(const struct rte_flow_item *item, @@ -625,10 +638,18 @@ ulp_rte_eth_hdr_handler(const struct rte_flow_item *item, field = ulp_rte_parser_fld_copy(¶ms->hdr_field[idx], eth_spec->dst.addr_bytes, size); + /* Todo: work around to avoid multicast and broadcast addr */ + if (ulp_rte_parser_is_bcmc_addr(ð_spec->dst)) + return BNXT_TF_RC_PARSE_ERR; + size = sizeof(eth_spec->src.addr_bytes); field = ulp_rte_parser_fld_copy(field, eth_spec->src.addr_bytes, size); + /* Todo: work around to avoid multicast and broadcast addr */ + if (ulp_rte_parser_is_bcmc_addr(ð_spec->src)) + return BNXT_TF_RC_PARSE_ERR; + field = ulp_rte_parser_fld_copy(field, ð_spec->type, sizeof(eth_spec->type));