[v1,1/1] net/ice: fix link status down
diff mbox series

Message ID 20200908224714.91088-1-yanx.fu@intel.com
State Rejected
Delegated to: Qi Zhang
Headers show
Series
  • [v1,1/1] net/ice: fix link status down
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

yanx.fu@intel.com Sept. 8, 2020, 10:47 p.m. UTC
From: FuYanX <yanx.fu@intel.com>

Add delay to ensure that the hardware FLR is completed.

Fixes: f9cf4f864150 (net/ice: support device initialization)
Cc: stable@dpdk.org

Signed-off-by: FuYanX <yanx.fu@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Mei, JianweiX Sept. 15, 2020, 6:54 a.m. UTC | #1
Tested-by:  Mei,JianweiX < jianweix.mei@intel.com>

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of yanx.fu@intel.com
Sent: Wednesday, September 9, 2020 6:47 AM
To: Zhang, Qi Z <qi.z.zhang@intel.com>; Guo, Jia <jia.guo@intel.com>
Cc: dev@dpdk.org; Fu, YanX <yanx.fu@intel.com>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH v1 1/1] net/ice: fix link status down

From: FuYanX <yanx.fu@intel.com>

Add delay to ensure that the hardware FLR is completed.

Fixes: f9cf4f864150 (net/ice: support device initialization)
Cc: stable@dpdk.org

Signed-off-by: FuYanX <yanx.fu@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 8d435e889..20bd85e62 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2176,6 +2176,11 @@ ice_dev_init(struct rte_eth_dev *dev)
 
 	ice_init_controlq_parameter(hw);
 
+	/* The driver e.g. vfio-pci may triggle a FLR reset.
+	 * The operating system is required by PCIe specification to wait 100 ms
+	 * before it can assume that the FLR sequence is completed by hardware.
+	 */
+	rte_delay_ms(100);
 	ret = ice_init_hw(hw);
 	if (ret) {
 		PMD_INIT_LOG(ERR, "Failed to initialize HW");
--
2.25.1

Patch
diff mbox series

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 8d435e889..20bd85e62 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2176,6 +2176,11 @@  ice_dev_init(struct rte_eth_dev *dev)
 
 	ice_init_controlq_parameter(hw);
 
+	/* The driver e.g. vfio-pci may triggle a FLR reset.
+	 * The operating system is required by PCIe specification to wait 100 ms
+	 * before it can assume that the FLR sequence is completed by hardware.
+	 */
+	rte_delay_ms(100);
 	ret = ice_init_hw(hw);
 	if (ret) {
 		PMD_INIT_LOG(ERR, "Failed to initialize HW");