diff mbox series

[RFC] app/testpmd: distinguish ICMP identifier fields in packet

Message ID 20200908100636.4575-1-lizh@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [RFC] app/testpmd: distinguish ICMP identifier fields in packet |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Li Zhang Sept. 8, 2020, 10:06 a.m. UTC 
  Ability to distinguish ICMP identifier fields in packets.
Dstinguish ICMP sequence number field too.
Already supports ICMP code and type fields in current version.
Existing fields in ICMP header contain the required information.
ICMP header already is supported and no code change in RTE FLOW.
Extend testpmd CLI to include the fields of ident and sequence number.
One example:
flow create 0 ingress pattern eth / ipv4 /
 icmp code is 1 ident is 5 seq is 6 /
 end actions count / queue index 0 / end
The ICMP packet with code 1, identifier 5 and
sequence number 6 will be matched.
It will implement action counter and forward to queue 0.

Signed-off-by: lizh <lizh@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Li Zhang Sept. 9, 2020, 3:41 a.m. UTC | #1 
Thanks! I update it now.

Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Tuesday, September 8, 2020 8:56 PM
To: Li Zhang <lizh@nvidia.com>
Cc: Dekel Peled <dekelp@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [RFC] app/testpmd: distinguish ICMP identifier fields in packet

External email: Use caution opening links or attachments


Hi,

lizh <lizh@nvidia.com> wrote:
> Ability to distinguish ICMP identifier fields in packets.
> Dstinguish ICMP sequence number field too.
> Already supports ICMP code and type fields in current version.
> Existing fields in ICMP header contain the required information.
> ICMP header already is supported and no code change in RTE FLOW.
> Extend testpmd CLI to include the fields of ident and sequence number.
> One example:
> flow create 0 ingress pattern eth / ipv4 /
>
>  icmp code is 1 ident is 5 seq is 6 /
>  end actions count / queue index 0 / end
>
> The ICMP packet with code 1, identifier 5 and sequence number 6 will 
> be matched.
> It will implement action counter and forward to queue 0.
>
> Signed-off-by: lizh <lizh@nvidia.com>

Please configure your git environment so that your full name is filled. Then redo the Signed-off so that it appears as:
        Li Zhang <lizh@nvidia.com>

As you are new to DPDK, I suggest reading the guidelines for contributing:
        https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcore.dpdk.org%2Fcontribute%2F%23send&amp;data=02%7C01%7Clizh%40nvidia.com%7C4d1f647de21844be83a408d853f69ab5%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637351665917806609&amp;sdata=dPG6VLa5HejKvwcGlqGKtfLwl%2BNEiybFSc5RUmmJDps%3D&amp;reserved=0
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 6263d307ed..6e04d538ea 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -143,6 +143,8 @@  enum index {
 	ITEM_ICMP,
 	ITEM_ICMP_TYPE,
 	ITEM_ICMP_CODE,
+	ITEM_ICMP_IDENT,
+	ITEM_ICMP_SEQ,
 	ITEM_UDP,
 	ITEM_UDP_SRC,
 	ITEM_UDP_DST,
@@ -893,6 +895,8 @@  static const enum index item_ipv6[] = {
 static const enum index item_icmp[] = {
 	ITEM_ICMP_TYPE,
 	ITEM_ICMP_CODE,
+	ITEM_ICMP_IDENT,
+	ITEM_ICMP_SEQ,
 	ITEM_NEXT,
 	ZERO,
 };
@@ -2193,6 +2197,20 @@  static const struct token token_list[] = {
 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
 					     hdr.icmp_code)),
 	},
+	[ITEM_ICMP_IDENT] = {
+		.name = "ident",
+		.help = "ICMP packet identifier",
+		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
+					     hdr.icmp_ident)),
+	},
+	[ITEM_ICMP_SEQ] = {
+		.name = "seq",
+		.help = "ICMP packet sequence number",
+		.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
+					     hdr.icmp_seq_nb)),
+	},
 	[ITEM_UDP] = {
 		.name = "udp",
 		.help = "match UDP header",