[v2,1/2] rte_log: take experimental tag off of rte_log_get_stream

Message ID 20200903230454.30602-2-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series rte_log: make internal structures private |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Sept. 3, 2020, 11:04 p.m. UTC
  Applications will need to use this API now to get internal
state of rte_log.

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_eal/include/rte_log.h   | 1 -
 lib/librte_eal/rte_eal_version.map | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
  

Comments

David Marchand Sept. 14, 2020, 8:12 a.m. UTC | #1
On Fri, Sep 4, 2020 at 1:05 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Applications will need to use this API now to get internal
> state of rte_log.
>
> Suggested-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_eal/include/rte_log.h   | 1 -
>  lib/librte_eal/rte_eal_version.map | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
> index eaf66e4f61de..7fe0968383db 100644
> --- a/lib/librte_eal/include/rte_log.h
> +++ b/lib/librte_eal/include/rte_log.h
> @@ -112,7 +112,6 @@ int rte_openlog_stream(FILE *f);
>   * @return
>   *   Pointer to the stream.
>   */
> -__rte_experimental
>  FILE *rte_log_get_stream(void);

There is still a banner in the function description.
I will fix it while applying.
  

Patch

diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
index eaf66e4f61de..7fe0968383db 100644
--- a/lib/librte_eal/include/rte_log.h
+++ b/lib/librte_eal/include/rte_log.h
@@ -112,7 +112,6 @@  int rte_openlog_stream(FILE *f);
  * @return
  *   Pointer to the stream.
  */
-__rte_experimental
 FILE *rte_log_get_stream(void);
 
 /**
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 0b18e2ef85f9..0564f2fdc7aa 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -109,6 +109,7 @@  DPDK_21 {
 	rte_log_dump;
 	rte_log_get_global_level;
 	rte_log_get_level;
+	rte_log_get_stream;
 	rte_log_register;
 	rte_log_set_global_level;
 	rte_log_set_level;
@@ -330,7 +331,6 @@  EXPERIMENTAL {
 	rte_rand_max;
 
 	# added in 19.11
-	rte_log_get_stream;
 	rte_mcfg_get_single_file_segments;
 
 	# added in 20.02