From patchwork Thu Sep 3 14:49:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 76408 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16DE5A04BF; Thu, 3 Sep 2020 16:50:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 667C61C0BC; Thu, 3 Sep 2020 16:49:56 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AD345DE0 for ; Thu, 3 Sep 2020 16:49:53 +0200 (CEST) IronPort-SDR: /UlXnPdkvFl/Zt+QXow74IhtO9wmHA2t3NBHPsyruproSuchuSfyFHsiSEKOenlu2eUNUyWLEy YUd8Z78j5Dhg== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="242403439" X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="242403439" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 07:49:53 -0700 IronPort-SDR: Iox/LzIUXkrEp8WQmvjDb6VRrcETQ0d1TVGofPi6QxlQtqJFNLpRrksIxGk4FsWDLiT8LYm9GR 1Iwg0RhDVhEw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="446930278" Received: from silpixa00399126.ir.intel.com ([10.237.222.27]) by orsmga004.jf.intel.com with ESMTP; 03 Sep 2020 07:49:51 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Ma Lihong , Hemant Agrawal , Bruce Richardson Date: Thu, 3 Sep 2020 15:49:40 +0100 Message-Id: <20200903144942.671870-2-bruce.richardson@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200903144942.671870-1-bruce.richardson@intel.com> References: <20200825114447.135030-1-bruce.richardson@intel.com> <20200903144942.671870-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/3] config: remove explicit undefinition of unset values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rather than explicitly clearing any setting of undefined values in our rte_config.h file, it's better to instead just add a comment that the value is not set. Using a comment allows the user to set the value using CFLAGS or similar mechanism without the config file clearing the value again. The text used " is not set" is modelled after the kernel approach of doing the same thing. Signed-off-by: Bruce Richardson --- Although DPDK coding convention forbids use of "//" for comments, using regular C comment style makes the config settings less clear, as they can be confused with regular comments in the file. Using "//" makes them stand out better, so I prefer it. However, if others feel strongly, they can be changed to standard. --- config/rte_config.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/config/rte_config.h b/config/rte_config.h index 9bb915347..1c5a86d6a 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -85,17 +85,17 @@ /* ip_fragmentation defines */ #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4 -#undef RTE_LIBRTE_IP_FRAG_TBL_STAT +// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set /* rte_power defines */ #define RTE_MAX_LCORE_FREQS 64 /* rte_sched defines */ -#undef RTE_SCHED_RED -#undef RTE_SCHED_COLLECT_STATS -#undef RTE_SCHED_SUBPORT_TC_OV +// RTE_SCHED_RED is not set +// RTE_SCHED_COLLECT_STATS is not set +// RTE_SCHED_SUBPORT_TC_OV is not set #define RTE_SCHED_PORT_N_GRINDERS 8 -#undef RTE_SCHED_VECTOR +// RTE_SCHED_VECTOR is not set /* KNI defines */ #define RTE_KNI_PREEMPT_DEFAULT 1 @@ -123,7 +123,7 @@ /* i40e defines */ #define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1 -#undef RTE_LIBRTE_I40E_16BYTE_RX_DESC +// RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4