diff mbox series

[v1,14/18] net/mlx5: remove indirection table type field

Message ID	1599128029-2092-15-git-send-email-michaelba@nvidia.com (mailing list archive)
State	Accepted, archived
Delegated to:	Raslan Darawsheh
Headers	From: Michael Baum <michaelba@nvidia.com> To: dev@dpdk.org Cc: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com> Date: Thu, 3 Sep 2020 10:13:45 +0000 Message-Id: <1599128029-2092-15-git-send-email-michaelba@nvidia.com> In-Reply-To: <1599128029-2092-1-git-send-email-michaelba@nvidia.com> References: <1599128029-2092-1-git-send-email-michaelba@nvidia.com> Subject: [dpdk-dev] [PATCH v1 14/18] net/mlx5: remove indirection table type field Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	mlx5 Rx DevX/Verbs separation \| [v1,00/18] mlx5 Rx DevX/Verbs separation [v1,01/18] net/mlx5: fix Rx hash queue creation error flow [v1,02/18] net/mlx5: fix Rx queue state update [v1,03/18] net/mlx5: fix types differentiation in Rxq create [v1,04/18] net/mlx5: mitigate Rx queue reference counters [v1,05/18] net/mlx5: separate Rx queue object creations [v1,06/18] net/mlx5: separate Rx interrupt handling [v1,07/18] net/mlx5: share Rx control code [v1,08/18] net/mlx5: rearrange the creation of RQ and CQ resources [v1,09/18] net/mlx5: rearrange the creation of WQ and CQ object [v1,10/18] net/mlx5: separate Rx queue object modification [v1,11/18] net/mlx5: share Rx queue object modification [v1,12/18] net/mlx5: separate Rx indirection table object creation [v1,13/18] net/mlx5: separate Rx hash queue creation [v1,14/18] net/mlx5: remove indirection table type field [v1,15/18] net/mlx5: share Rx queue indirection table code [v1,16/18] net/mlx5: share Rx hash queue code [v1,17/18] net/mlx5: separate Rx queue drop [v1,18/18] net/mlx5: share Rx queue drop action code

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Michael Baum Sept. 3, 2020, 10:13 a.m. UTC

  Once the separation between Verbs and DevX is done using function
pointers, the type field of the indirection table structure becomes
redundant and no more code is used.
Remove the unnecessary field from the structure.

Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/linux/mlx5_verbs.c | 1 -
 drivers/net/mlx5/mlx5.h             | 6 ------
 drivers/net/mlx5/mlx5_devx.c        | 1 -
 3 files changed, 8 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c b/drivers/net/mlx5/linux/mlx5_verbs.c
index d92dd48..6eef85e 100644
--- a/drivers/net/mlx5/linux/mlx5_verbs.c
+++ b/drivers/net/mlx5/linux/mlx5_verbs.c
@@ -471,7 +471,6 @@ 
 		rte_errno = ENOMEM;
 		return NULL;
 	}
-	ind_tbl->type = MLX5_IND_TBL_TYPE_IBV;
 	for (i = 0; i != queues_n; ++i) {
 		struct mlx5_rxq_ctrl *rxq = mlx5_rxq_get(dev, queues[i]);
 		if (!rxq)
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 9fc4639..9594856 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -704,16 +704,10 @@  struct mlx5_rxq_obj {
 	};
 };
 
-enum mlx5_ind_tbl_type {
-	MLX5_IND_TBL_TYPE_IBV,
-	MLX5_IND_TBL_TYPE_DEVX,
-};
-
 /* Indirection table. */
 struct mlx5_ind_table_obj {
 	LIST_ENTRY(mlx5_ind_table_obj) next; /* Pointer to the next element. */
 	rte_atomic32_t refcnt; /* Reference counter. */
-	enum mlx5_ind_tbl_type type;
 	RTE_STD_C11
 	union {
 		void *ind_table; /**< Indirection table. */
diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
index b1b3037..5fa41f1 100644
--- a/drivers/net/mlx5/mlx5_devx.c
+++ b/drivers/net/mlx5/mlx5_devx.c
@@ -639,7 +639,6 @@ 
 		rte_errno = ENOMEM;
 		return NULL;
 	}
-	ind_tbl->type = MLX5_IND_TBL_TYPE_DEVX;
 	rqt_attr = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*rqt_attr) +
 			      rqt_n * sizeof(uint32_t), 0, SOCKET_ID_ANY);
 	if (!rqt_attr) {