cryptodev: remove crypto list end enumerators
diff mbox series

Message ID 20200902150155.406-1-arkadiuszx.kusztal@intel.com
State Changes Requested
Delegated to: akhil goyal
Headers show
Series
  • cryptodev: remove crypto list end enumerators
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS

Commit Message

Arek Kusztal Sept. 2, 2020, 3:01 p.m. UTC
This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
some problems that may arise when adding new crypto algorithms.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/librte_cryptodev/rte_crypto_sym.h | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Comments

Trahe, Fiona Sept. 2, 2020, 3:11 p.m. UTC | #1
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Wednesday, September 2, 2020 4:02 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] cryptodev: remove crypto list end enumerators
> 
> This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> some problems that may arise when adding new crypto algorithms.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Akhil Goyal Sept. 10, 2020, 6:57 p.m. UTC | #2
Hi Arek,

> This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> some problems that may arise when adding new crypto algorithms.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---

There is a deprecation notice to remove these enums.
You should remove that.
Please have a single series for removal of all LIST END including the Asym crypto.

And I can see that these **LIST_END are getting used in some of the crypto PMDs.
Please remove all those references and cc changes to the respective PMD maintainer.

Regards,
Akhil
Arek Kusztal Sept. 11, 2020, 5:14 a.m. UTC | #3
HI Akhil,

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: czwartek, 10 września 2020 20:57
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH] cryptodev: remove crypto list end enumerators
> 
> Hi Arek,
> 
> > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> some
> > problems that may arise when adding new crypto algorithms.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> 
> There is a deprecation notice to remove these enums.
> You should remove that.
> Please have a single series for removal of all LIST END including the Asym crypto.

Reason that I have removed LIST_ENDs separately from symmetric and asymmetric is that asymmetric
API Is experimental so it did not need notice, but if really needed I can combine it into one patch in v2.

> 
> And I can see that these **LIST_END are getting used in some of the crypto
> PMDs.
> Please remove all those references and cc changes to the respective PMD
> maintainer.

I have informed "off the list" maintainers of PMDs that are using LIST_ENDS about this patch, so they should be sending patches soon, but if needed I can do it too in v2.


> 
> Regards,
> Akhil
Akhil Goyal Sept. 11, 2020, 6:10 a.m. UTC | #4
Hi Arek,
> 
> HI Akhil,
> 
> > > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> > some
> > > problems that may arise when adding new crypto algorithms.
> > >
> > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > ---
> >
> > There is a deprecation notice to remove these enums.
> > You should remove that.
> > Please have a single series for removal of all LIST END including the Asym
> crypto.
> 
> Reason that I have removed LIST_ENDs separately from symmetric and
> asymmetric is that asymmetric
> API Is experimental so it did not need notice, but if really needed I can combine
> it into one patch in v2.
> 
I was talking about a series of patches. Different patches in a series.

> >
> > And I can see that these **LIST_END are getting used in some of the crypto
> > PMDs.
> > Please remove all those references and cc changes to the respective PMD
> > maintainer.
> 
> I have informed "off the list" maintainers of PMDs that are using LIST_ENDS
> about this patch, so they should be sending patches soon, but if needed I can do
> it too in v2.
> 
You can add them in your v2 and cc maintainers.
Arek Kusztal Sept. 11, 2020, 6:13 a.m. UTC | #5
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: piątek, 11 września 2020 08:10
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH] cryptodev: remove crypto list end enumerators
> 
> Hi Arek,
> >
> > HI Akhil,
> >
> > > > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > > > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> > > some
> > > > problems that may arise when adding new crypto algorithms.
> > > >
> > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > > ---
> > >
> > > There is a deprecation notice to remove these enums.
> > > You should remove that.
> > > Please have a single series for removal of all LIST END including
> > > the Asym
> > crypto.
> >
> > Reason that I have removed LIST_ENDs separately from symmetric and
> > asymmetric is that asymmetric API Is experimental so it did not need
> > notice, but if really needed I can combine it into one patch in v2.
> >
> I was talking about a series of patches. Different patches in a series.
Ah, I got it now, no problem.
> 
> > >
> > > And I can see that these **LIST_END are getting used in some of the
> > > crypto PMDs.
> > > Please remove all those references and cc changes to the respective
> > > PMD maintainer.
> >
> > I have informed "off the list" maintainers of PMDs that are using
> > LIST_ENDS about this patch, so they should be sending patches soon,
> > but if needed I can do it too in v2.
> >
> You can add them in your v2 and cc maintainers.

Patch
diff mbox series

diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h
index f29c98051..7a2556a9e 100644
--- a/lib/librte_cryptodev/rte_crypto_sym.h
+++ b/lib/librte_cryptodev/rte_crypto_sym.h
@@ -132,15 +132,12 @@  enum rte_crypto_cipher_algorithm {
 	 * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
 	 */
 
-	RTE_CRYPTO_CIPHER_DES_DOCSISBPI,
+	RTE_CRYPTO_CIPHER_DES_DOCSISBPI
 	/**< DES algorithm using modes required by
 	 * DOCSIS Baseline Privacy Plus Spec.
 	 * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next
 	 * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
 	 */
-
-	RTE_CRYPTO_CIPHER_LIST_END
-
 };
 
 /** Cipher algorithm name strings */
@@ -312,10 +309,8 @@  enum rte_crypto_auth_algorithm {
 	/**< HMAC using 384 bit SHA3 algorithm. */
 	RTE_CRYPTO_AUTH_SHA3_512,
 	/**< 512 bit SHA3 algorithm. */
-	RTE_CRYPTO_AUTH_SHA3_512_HMAC,
+	RTE_CRYPTO_AUTH_SHA3_512_HMAC
 	/**< HMAC using 512 bit SHA3 algorithm. */
-
-	RTE_CRYPTO_AUTH_LIST_END
 };
 
 /** Authentication algorithm name strings */
@@ -412,9 +407,8 @@  enum rte_crypto_aead_algorithm {
 	/**< AES algorithm in CCM mode. */
 	RTE_CRYPTO_AEAD_AES_GCM,
 	/**< AES algorithm in GCM mode. */
-	RTE_CRYPTO_AEAD_CHACHA20_POLY1305,
+	RTE_CRYPTO_AEAD_CHACHA20_POLY1305
 	/**< Chacha20 cipher with poly1305 authenticator */
-	RTE_CRYPTO_AEAD_LIST_END
 };
 
 /** AEAD algorithm name strings */