net/iavf: fix mismatch command
diff mbox series

Message ID 20200901081436.34963-1-junyux.jiang@intel.com
State Accepted, archived
Delegated to: Qi Zhang
Headers show
Series
  • net/iavf: fix mismatch command
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Junyu Jiang Sept. 1, 2020, 8:14 a.m. UTC
The "command mismatch" warning shouldn't be triggered by
VIRTCHNL_OP_EVENT opcode, because the VIRTCHNL_OP_EVENT
opcode is used by PF notifies status change events to VF.
This patch fixed the issue.

Fixes: 837c2ed86e4c ("net/iavf: return error if opcode is mismatched")
Cc: stable@dpdk.org

Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
 drivers/net/iavf/iavf_vchnl.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Yang, Qiming Sept. 3, 2020, 1:50 a.m. UTC | #1
> -----Original Message-----
> From: Jiang, JunyuX <junyux.jiang@intel.com>
> Sent: 2020年9月1日 16:15
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>; Jiang, JunyuX
> <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix mismatch command
> 
> The "command mismatch" warning shouldn't be triggered by
> VIRTCHNL_OP_EVENT opcode, because the VIRTCHNL_OP_EVENT opcode is
> used by PF notifies status change events to VF.
> This patch fixed the issue.
> 
> Fixes: 837c2ed86e4c ("net/iavf: return error if opcode is mismatched")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  drivers/net/iavf/iavf_vchnl.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> 33acea54a..331018f14 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -53,8 +53,11 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter,
> uint16_t buf_len,
>  		    opcode, vf->cmd_retval);
> 
>  	if (opcode != vf->pend_cmd) {
> -		PMD_DRV_LOG(WARNING, "command mismatch, expect %u,
> get %u",
> -			    vf->pend_cmd, opcode);
> +		if (opcode != VIRTCHNL_OP_EVENT) {
> +			PMD_DRV_LOG(WARNING,
> +				    "command mismatch, expect %u, get %u",
> +				    vf->pend_cmd, opcode);
> +		}
>  		return IAVF_ERR_OPCODE_MISMATCH;
>  	}
> 
> --
> 2.17.1
Reviewed-by: Qiming Yang <qiming.yang@intel.com>
Zhang, Qi Z Sept. 3, 2020, 2:17 p.m. UTC | #2
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Yang, Qiming
> Sent: Thursday, September 3, 2020 9:51 AM
> To: Jiang, JunyuX <junyux.jiang@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix mismatch command
> 
> 
> 
> > -----Original Message-----
> > From: Jiang, JunyuX <junyux.jiang@intel.com>
> > Sent: 2020年9月1日 16:15
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Jiang,
> > JunyuX <junyux.jiang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/iavf: fix mismatch command
> >
> > The "command mismatch" warning shouldn't be triggered by
> > VIRTCHNL_OP_EVENT opcode, because the VIRTCHNL_OP_EVENT opcode is
> used
> > by PF notifies status change events to VF.
> > This patch fixed the issue.
> >
> > Fixes: 837c2ed86e4c ("net/iavf: return error if opcode is mismatched")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> > ---
> >  drivers/net/iavf/iavf_vchnl.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/iavf/iavf_vchnl.c
> > b/drivers/net/iavf/iavf_vchnl.c index
> > 33acea54a..331018f14 100644
> > --- a/drivers/net/iavf/iavf_vchnl.c
> > +++ b/drivers/net/iavf/iavf_vchnl.c
> > @@ -53,8 +53,11 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter,
> > uint16_t buf_len,
> >  		    opcode, vf->cmd_retval);
> >
> >  	if (opcode != vf->pend_cmd) {
> > -		PMD_DRV_LOG(WARNING, "command mismatch, expect %u,
> > get %u",
> > -			    vf->pend_cmd, opcode);
> > +		if (opcode != VIRTCHNL_OP_EVENT) {
> > +			PMD_DRV_LOG(WARNING,
> > +				    "command mismatch, expect %u, get %u",
> > +				    vf->pend_cmd, opcode);
> > +		}
> >  		return IAVF_ERR_OPCODE_MISMATCH;
> >  	}
> >
> > --
> > 2.17.1
> Reviewed-by: Qiming Yang <qiming.yang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

Patch
diff mbox series

diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 33acea54a..331018f14 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -53,8 +53,11 @@  iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len,
 		    opcode, vf->cmd_retval);
 
 	if (opcode != vf->pend_cmd) {
-		PMD_DRV_LOG(WARNING, "command mismatch, expect %u, get %u",
-			    vf->pend_cmd, opcode);
+		if (opcode != VIRTCHNL_OP_EVENT) {
+			PMD_DRV_LOG(WARNING,
+				    "command mismatch, expect %u, get %u",
+				    vf->pend_cmd, opcode);
+		}
 		return IAVF_ERR_OPCODE_MISMATCH;
 	}