diff mbox series

net/iavf: fix default mac set fail issue

Message ID 1598324444-24734-1-git-send-email-han.li1@zte.com.cn (mailing list archive)
State Rejected, archived
Delegated to: Qi Zhang
Headers
Series net/iavf: fix default mac set fail issue |

Checks

Context Check Description
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/checkpatch warning coding style issues

Commit Message

Li Han Aug. 25, 2020, 3 a.m. UTC 
  rte_is_valid_assigned_ether_addr retrun true
if the given ethernet address is valid.

Signed-off-by: Li Han <han.li1@zte.com.cn>
---
 drivers/net/iavf/iavf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qi Zhang Aug. 31, 2020, 8:27 a.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Li Han
> Sent: Tuesday, August 25, 2020 11:01 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Li Han <han.li1@zte.com.cn>
> Subject: [dpdk-dev] [PATCH] net/iavf: fix default mac set fail issue
> 
> rte_is_valid_assigned_ether_addr retrun true if the given ethernet address is
> valid.
> 
> Signed-off-by: Li Han <han.li1@zte.com.cn>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index c3aa4cd..18ce809 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -973,7 +973,7 @@ static int iavf_config_rx_queues_irqs(struct
> rte_eth_dev *dev,
>  		return 0;
> 
>  	/* If the MAC address is configured by host, skip the setting */
> -	if (rte_is_valid_assigned_ether_addr(perm_addr))
> +	if (!rte_is_valid_assigned_ether_addr(perm_addr))

A valid mac address means it already be configured by host, so it should be skipped.

>  		return -EPERM;
> 
>  	ret = iavf_add_del_eth_addr(adapter, old_addr, false);
> --
> 1.8.3.1
diff mbox series

Patch

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index c3aa4cd..18ce809 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -973,7 +973,7 @@  static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 		return 0;
 
 	/* If the MAC address is configured by host, skip the setting */
-	if (rte_is_valid_assigned_ether_addr(perm_addr))
+	if (!rte_is_valid_assigned_ether_addr(perm_addr))
 		return -EPERM;
 
 	ret = iavf_add_del_eth_addr(adapter, old_addr, false);