[v2] Fixes: 57f90f894588("net/virtio: reuse packed ring functions")
diff mbox series

Message ID 20200812092306.1345-1-vipul.ashri@oracle.com
State Superseded
Delegated to: Maxime Coquelin
Headers show
Series
  • [v2] Fixes: 57f90f894588("net/virtio: reuse packed ring functions")
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing warning Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/checkpatch warning coding style issues

Commit Message

Vipul Ashri Aug. 12, 2020, 9:23 a.m. UTC
Problem - Standard Tx packets are not going out and found broken
 due to cleanup malfunctioning whereever below mentioned macro is
 used.

RootCause - Here inside Macro 'ASSIGN_UNLESS_EQUAL(var, val)'
 assignment to 'var' argument passed is always failing as assignment
 done using 'var_' having local scope only.

Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>
---
 drivers/net/virtio/virtqueue.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Patch
diff mbox series

diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 105a9c00c..20c95471e 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -607,10 +607,8 @@  virtqueue_notify(struct virtqueue *vq)
 
 /* avoid write operation when necessary, to lessen cache issues */
 #define ASSIGN_UNLESS_EQUAL(var, val) do {	\
-	typeof(var) var_ = (var);		\
-	typeof(val) val_ = (val);		\
-	if ((var_) != (val_))			\
-		(var_) = (val_);		\
+	if ((var) != (val))			\
+		(var) = (val);			\
 } while (0)
 
 #define virtqueue_clear_net_hdr(hdr) do {		\