[V1] tests/kernelpf_iavf: remove extra code
diff mbox series

Message ID 20200811151108.26158-1-jianweix.mei@intel.com
State Accepted
Headers show
Series
  • [V1] tests/kernelpf_iavf: remove extra code
Related show

Commit Message

Mei, JianweiX Aug. 11, 2020, 3:11 p.m. UTC
Same command in tear down, and if it is executed before the quit command, 
an error will occur, so delete them from test case.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 3 ---
 1 file changed, 3 deletions(-)

Comments

Xie, WeiX Aug. 11, 2020, 6:44 a.m. UTC | #1
Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei
Sent: Tuesday, August 11, 2020 11:11 PM
To: dts@dpdk.org
Cc: Mei, JianweiX <jianweix.mei@intel.com>
Subject: [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code

Same command in tear down, and if it is executed before the quit command, an error will occur, so delete them from test case.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 733d72f..f8fa94f 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -335,8 +335,6 @@ class TestKernelpfIavf(TestCase):
         out = self.vm_dut.get_session_output()
         self.verify(self.wrong_mac in out, 'vf receive pkt fail with wrong mac')
 
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
-
     def test_vf_multicast(self):
         """
         enable kernel trust mode
@@ -363,7 +361,6 @@ class TestKernelpfIavf(TestCase):
         self.send_random_pkt(multicast_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(multicast_mac in out, 'vf receive pkt fail with multicast mac')
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
 
     def test_vf_broadcast(self):
         """
--
2.17.1
Tu, Lijuan Aug. 13, 2020, 5:39 a.m. UTC | #2
> Subject: [dts] [PATCH V1] tests/kernelpf_iavf: remove extra code
> 
> Same command in tear down, and if it is executed before the quit command, an
> error will occur, so delete them from test case.
> 
> Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 3 ---

Applied

Patch
diff mbox series

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 733d72f..f8fa94f 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -335,8 +335,6 @@  class TestKernelpfIavf(TestCase):
         out = self.vm_dut.get_session_output()
         self.verify(self.wrong_mac in out, 'vf receive pkt fail with wrong mac')
 
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
-
     def test_vf_multicast(self):
         """
         enable kernel trust mode
@@ -363,7 +361,6 @@  class TestKernelpfIavf(TestCase):
         self.send_random_pkt(multicast_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(multicast_mac in out, 'vf receive pkt fail with multicast mac')
-        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
 
     def test_vf_broadcast(self):
         """