diff mbox series

doc: announce move of aes gmac algorithm to aead

Message ID 20200805142457.1316-1-arkadiuszx.kusztal@intel.com (mailing list archive)
State Superseded, archived
Headers
Series doc: announce move of aes gmac algorithm to aead |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Arkadiusz Kusztal Aug. 5, 2020, 2:24 p.m. UTC 
  This patch announces removal of RTE_CRYPTO_AUTH_AES_GMAC
from rte_crypto_auth_algorithm and addition of RTE_CRYPTO_AEAD_AES_GMAC
to rte_crypto_aead_algorithm.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Akhil Goyal Aug. 5, 2020, 2:36 p.m. UTC | #1 
> This patch announces removal of RTE_CRYPTO_AUTH_AES_GMAC
> from rte_crypto_auth_algorithm and addition of
> RTE_CRYPTO_AEAD_AES_GMAC
> to rte_crypto_aead_algorithm.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Akhil Goyal Aug. 5, 2020, 2:39 p.m. UTC | #2 
> Subject: RE: [PATCH] doc: announce move of aes gmac algorithm to aead
> 
> > This patch announces removal of RTE_CRYPTO_AUTH_AES_GMAC
> > from rte_crypto_auth_algorithm and addition of
> > RTE_CRYPTO_AEAD_AES_GMAC
> > to rte_crypto_aead_algorithm.
> >

You should probably explain the reason of this migration in the description.

> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Arkadiusz Kusztal Aug. 5, 2020, 2:54 p.m. UTC | #3 
I will send v2 soon then.

-----Original Message-----
From: Akhil Goyal <akhil.goyal@nxp.com> 
Sent: środa, 5 sierpnia 2020 16:40
To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
Cc: anoobj@marvell.com; Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; asomalap@amd.com; rnagadheeraj@marvell.com; Hemant Agrawal <hemant.agrawal@nxp.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>
Subject: RE: [PATCH] doc: announce move of aes gmac algorithm to aead

> Subject: RE: [PATCH] doc: announce move of aes gmac algorithm to aead
> 
> > This patch announces removal of RTE_CRYPTO_AUTH_AES_GMAC from 
> > rte_crypto_auth_algorithm and addition of RTE_CRYPTO_AEAD_AES_GMAC 
> > to rte_crypto_aead_algorithm.
> >

You should probably explain the reason of this migration in the description.

> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7..6fe12b0 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -151,3 +151,7 @@  Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* cryptodev: ``RTE_CRYPTO_AUTH_AES_GMAC`` will no longer be included in
+  ``enum rte_crypto_auth_algorithm``. It will be included in
+  ``enum rte_crypto_aead_algorithm`` as ``RTE_CRYPTO_AEAD_AES_GMAC``.