doc: announce ethdev port freeing on close operation
diff mbox series

Message ID 20200804092014.3335076-1-thomas@monjalon.net
State Accepted, archived
Headers show
Series
  • doc: announce ethdev port freeing on close operation
Related show

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Thomas Monjalon Aug. 4, 2020, 9:20 a.m. UTC
Since DPDK 18.11, some drivers are migrating to a new behaviour,
releasing port resources on close.
The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
in the migrated drivers.
After 2 years, the flag and the old behaviour will be removed.
Last drivers not migrated will have to complete the switch.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Jerin Jacob Aug. 4, 2020, 9:22 a.m. UTC | #1
On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Since DPDK 18.11, some drivers are migrating to a new behaviour,
> releasing port resources on close.
> The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
> in the migrated drivers.
> After 2 years, the flag and the old behaviour will be removed.
> Last drivers not migrated will have to complete the switch.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Jerin Jacob <jerinj@marvell.com>



> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7a48..b5e8045d00 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -91,6 +91,12 @@ Deprecation Notices
>    - ``rte_eth_dev_stop``
>    - ``rte_eth_dev_close``
>
> +* ethdev: The temporary flag RTE_ETH_DEV_CLOSE_REMOVE will be removed in 20.11.
> +  As a consequence, the new behaviour introduced in 18.11 will be effective
> +  for all drivers: generic port resources are freed on close operation.
> +  Private resources are expected to be released in the ``dev_close`` callback.
> +  More details in http://inbox.dpdk.org/dev/5248162.j6AOsuQRmx@thomas/
> +
>  * ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11.
>    This will allow application to enable or disable PMDs from updating
>    ``rte_mbuf::hash::fdir``.
> --
> 2.27.0
>
Hemant Agrawal Aug. 4, 2020, 9:29 a.m. UTC | #2
> On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > Since DPDK 18.11, some drivers are migrating to a new behaviour,
> > releasing port resources on close.
> > The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
> in
> > the migrated drivers.
> > After 2 years, the flag and the old behaviour will be removed.
> > Last drivers not migrated will have to complete the switch.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Ajit Khaparde Aug. 4, 2020, 5:34 p.m. UTC | #3
On Tue, Aug 4, 2020 at 2:29 AM Hemant Agrawal <hemant.agrawal@nxp.com>
wrote:

> > On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net>
> > wrote:
> > >
> > > Since DPDK 18.11, some drivers are migrating to a new behaviour,
> > > releasing port resources on close.
> > > The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
> > in
> > > the migrated drivers.
> > > After 2 years, the flag and the old behaviour will be removed.
> > > Last drivers not migrated will have to complete the switch.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Andrew Rybchenko Aug. 5, 2020, 10:33 a.m. UTC | #4
On 8/4/20 8:34 PM, Ajit Khaparde wrote:
> On Tue, Aug 4, 2020 at 2:29 AM Hemant Agrawal <hemant.agrawal@nxp.com>
> wrote:
> 
>>> On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net>
>>> wrote:
>>>>
>>>> Since DPDK 18.11, some drivers are migrating to a new behaviour,
>>>> releasing port resources on close.
>>>> The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
>>> in
>>>> the migrated drivers.
>>>> After 2 years, the flag and the old behaviour will be removed.
>>>> Last drivers not migrated will have to complete the switch.
>>>>
>>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>>
>> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Thomas Monjalon Aug. 6, 2020, 12:18 a.m. UTC | #5
05/08/2020 12:33, Andrew Rybchenko:
> On 8/4/20 8:34 PM, Ajit Khaparde wrote:
> > On Tue, Aug 4, 2020 at 2:29 AM Hemant Agrawal <hemant.agrawal@nxp.com>
> > wrote:
> > 
> >>> On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net>
> >>> wrote:
> >>>>
> >>>> Since DPDK 18.11, some drivers are migrating to a new behaviour,
> >>>> releasing port resources on close.
> >>>> The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
> >>> in
> >>>> the migrated drivers.
> >>>> After 2 years, the flag and the old behaviour will be removed.
> >>>> Last drivers not migrated will have to complete the switch.
> >>>>
> >>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> >> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied

Patch
diff mbox series

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7a48..b5e8045d00 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -91,6 +91,12 @@  Deprecation Notices
   - ``rte_eth_dev_stop``
   - ``rte_eth_dev_close``
 
+* ethdev: The temporary flag RTE_ETH_DEV_CLOSE_REMOVE will be removed in 20.11.
+  As a consequence, the new behaviour introduced in 18.11 will be effective
+  for all drivers: generic port resources are freed on close operation.
+  Private resources are expected to be released in the ``dev_close`` callback.
+  More details in http://inbox.dpdk.org/dev/5248162.j6AOsuQRmx@thomas/
+
 * ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11.
   This will allow application to enable or disable PMDs from updating
   ``rte_mbuf::hash::fdir``.