librte_metrics: fix memory leak
Checks
Commit Message
Fix memory leak for sequential allocations.
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
---
lib/librte_metrics/rte_metrics_telemetry.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
@@ -41,11 +41,18 @@ rte_metrics_tel_reg_port_ethdev_to_metrics(uint16_t port_id)
}
xstats_names = malloc(sizeof(*xstats_names) * num_xstats);
+ if (xstats_names == NULL) {
+ METRICS_LOG_ERR("Failed to malloc memory for xstats_names");
+ ret = -ENOMEM;
+ goto free_xstats;
+ }
+
eth_xstats_names = malloc(sizeof(struct rte_eth_xstat_name)
* num_xstats);
- if (eth_xstats_names == NULL || xstats_names == NULL) {
+ if (eth_xstats_names == NULL) {
METRICS_LOG_ERR("Failed to malloc memory for xstats_names");
ret = -ENOMEM;
+ free(xstats_names);
goto free_xstats;
}
@@ -167,9 +174,15 @@ rte_metrics_tel_format_port(uint32_t pid, json_t *ports,
}
metrics = malloc(sizeof(struct rte_metric_value) * num_metrics);
+ if (metrics == NULL) {
+ METRICS_LOG_ERR("Cannot allocate memory");
+ return -ENOMEM;
+ }
+
names = malloc(sizeof(struct rte_metric_name) * num_metrics);
- if (metrics == NULL || names == NULL) {
+ if (names == NULL) {
METRICS_LOG_ERR("Cannot allocate memory");
+ free(metrics);
return -ENOMEM;
}