[v1] common/mlx5: fix set regex register layout
Checks
Commit Message
Reserved field should be 0x60 instead of 0x40.
Will fail FW check otherwise.
Fixes: be4f4a8b8e3b ("regex/mlx5: add engine status check")
Signed-off-by: Yuval Avnery <yuvalav@mellanox.com>
Acked-by: Ori Kam <orika@mellanox.com>
---
drivers/common/mlx5/mlx5_prm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Yuval Avnery
> Sent: Tuesday, July 28, 2020 8:51 PM
> To: Matan Azrad <matan@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org; Yuval
> Avnery <yuvalav@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [dpdk-dev] [PATCH v1] common/mlx5: fix set regex register layout
>
> Reserved field should be 0x60 instead of 0x40.
> Will fail FW check otherwise.
>
> Fixes: be4f4a8b8e3b ("regex/mlx5: add engine status check")
> Signed-off-by: Yuval Avnery <yuvalav@mellanox.com>
> Acked-by: Ori Kam <orika@mellanox.com>
> ---
> drivers/common/mlx5/mlx5_prm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/mlx5/mlx5_prm.h
> b/drivers/common/mlx5/mlx5_prm.h
> index 8fab962..c78b462 100644
> --- a/drivers/common/mlx5/mlx5_prm.h
> +++ b/drivers/common/mlx5/mlx5_prm.h
> @@ -2789,7 +2789,7 @@ struct mlx5_ifc_set_regexp_register_in_bits {
> u8 engine_id[0x8];
> u8 register_address[0x20];
> u8 register_data[0x20];
> - u8 reserved[0x40];
> + u8 reserved[0x60];
> };
>
> struct mlx5_ifc_set_regexp_register_out_bits {
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
@@ -2789,7 +2789,7 @@ struct mlx5_ifc_set_regexp_register_in_bits {
u8 engine_id[0x8];
u8 register_address[0x20];
u8 register_data[0x20];
- u8 reserved[0x40];
+ u8 reserved[0x60];
};
struct mlx5_ifc_set_regexp_register_out_bits {