doc: update release notes for mlx5 PMD
diff mbox series

Message ID 1595159969-267315-1-git-send-email-suanmingm@mellanox.com
State Accepted
Delegated to: Raslan Darawsheh
Headers show
Series
  • doc: update release notes for mlx5 PMD
Related show

Checks

Context Check Description
ci/Intel-compilation fail apply issues
ci/checkpatch success coding style OK

Commit Message

Suanming Mou July 19, 2020, 11:59 a.m. UTC
Update the release notes of mlx5 PMD for two new added devargs:
1. sys_mem_en
2. decap_en

Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
---
 doc/guides/rel_notes/release_20_08.rst | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon Aug. 5, 2020, 3:31 p.m. UTC | #1
19/07/2020 13:59, Suanming Mou:
> Update the release notes of mlx5 PMD for two new added devargs:
> 1. sys_mem_en
> 2. decap_en

That's a pity it was not sent as part of code implementation.

Please, at least, add the Fixes lines.

> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> ---
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -123,6 +123,8 @@ New Features
>    * Added new PMD devarg ``reclaim_mem_mode``.
>    * Added new devarg ``lacp_by_user``.
>    * Added support for eCPRI protocol offloading.
> +  * Added new devarg ``decap_en``.
> +  * Added new devarg ``sys_mem_en``.

You could group by moving up with other devargs in a logical order.
I think we could even group all devargs in a single list item.
Suanming Mou Aug. 6, 2020, 12:57 a.m. UTC | #2
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, August 5, 2020 11:31 PM
> To: Suanming Mou <suanmingm@mellanox.com>
> Cc: John McNamara <john.mcnamara@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>; dev@dpdk.org; Raslan Darawsheh
> <rasland@mellanox.com>; Asaf Penso <asafp@mellanox.com>; Gal Cohen
> (Product) <galco@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: update release notes for mlx5 PMD
> 
> 19/07/2020 13:59, Suanming Mou:
> > Update the release notes of mlx5 PMD for two new added devargs:
> > 1. sys_mem_en
> > 2. decap_en
> 
> That's a pity it was not sent as part of code implementation.
> 
> Please, at least, add the Fixes lines.
OK, will add the Fixes lines.
> 
> > Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> > ---
> > --- a/doc/guides/rel_notes/release_20_08.rst
> > +++ b/doc/guides/rel_notes/release_20_08.rst
> > @@ -123,6 +123,8 @@ New Features
> >    * Added new PMD devarg ``reclaim_mem_mode``.
> >    * Added new devarg ``lacp_by_user``.
> >    * Added support for eCPRI protocol offloading.
> > +  * Added new devarg ``decap_en``.
> > +  * Added new devarg ``sys_mem_en``.
> 
> You could group by moving up with other devargs in a logical order.
> I think we could even group all devargs in a single list item.
Good idea. Thanks.
> 
>

Patch
diff mbox series

diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index 917a5b8..43e20c6 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -123,6 +123,8 @@  New Features
   * Added new PMD devarg ``reclaim_mem_mode``.
   * Added new devarg ``lacp_by_user``.
   * Added support for eCPRI protocol offloading.
+  * Added new devarg ``decap_en``.
+  * Added new devarg ``sys_mem_en``.
 
 * **Added vDPA device APIs to query virtio queue statistics.**