From patchwork Tue Jul 14 15:58:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Bilal X-Patchwork-Id: 74016 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85DE4A0540; Tue, 14 Jul 2020 18:02:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B9791D421; Tue, 14 Jul 2020 18:02:42 +0200 (CEST) Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by dpdk.org (Postfix) with ESMTP id 295C31D41C for ; Tue, 14 Jul 2020 18:02:41 +0200 (CEST) Received: by mail-ej1-f67.google.com with SMTP id n26so22668231ejx.0 for ; Tue, 14 Jul 2020 09:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZRi0MiT4b2bWgpveGj1J4MqWRHl8KOKOxqLqcc1y1OM=; b=sQdASSShNF45VRcsiGYM1egj3Jgl+UcAanhIQcmU85Ix7DYAOJS0rVF4FKGBOwn74A sMirDnIdgfAZCKAJRxToeukllddPgZJuo393UfdnDj0QsjYAOSODSy3g+4Ly+orVgDJx OCvo4LgOVBSLob6dl0xmpzve/iuXO31/V2u07iZ5Z+qg3smwyt4AV6jf2rhk7kpoSLm9 tFshFlZhFS8e5ujrwIv406Bh8hOj300xX/nKcyNucFd3TRnA4RGFips/KL1FN6BHXcEF p7MZq15O9xfEGRAkKS8JTicfbKC31e7G6Lw1BA1jAPrvlBd4iTibRK2BCiU7MCVjOAPk qgJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZRi0MiT4b2bWgpveGj1J4MqWRHl8KOKOxqLqcc1y1OM=; b=BTyuXjXaSOez8YNc0jOg81HLRrrgHrcrSyYE2yUmB2TxD49cY1xHO8DYw9NH0JKy0e uRh2E4deq+j+lyL3bgBb7gYDM3xWEuZNeX+vkZDfjCOmWeUOfnL6/qKy++4DMOf72Eph VJAjNYw8rxKdA1LDSLgoBSPvgYuyj++ch+WfuwgXdkU1JGgc2zBXer6jVcjoMOnzBWkl XUpO7juOGL5FpcdwILW9R8vczypueO/TjZgrRaf81JW41iQrtaIXoMhmYe5M/oh5a/xk 9skC508OJj9ivAuXzaFlMNYX4ZtDg66w0yl09OLZ/PwYAEZ5bt2L7gEI4gNEX6HLnhA3 fEbA== X-Gm-Message-State: AOAM532Ojr9MaHHPGfb1/RjBoh2kQYgTgqnRBVOaCAaor75ynfyo/iZW i3F9jZVKhQ21oQlzFp5LbeVqU7t1yZc= X-Google-Smtp-Source: ABdhPJwJtpo94yf9KKXlpYgFUrJBzojdT0st8ohzIgYvGy4C1TZ5uBGSjmVUxV+Kf07AEdRCISz5Zw== X-Received: by 2002:a17:906:3984:: with SMTP id h4mr5450353eje.254.1594742560881; Tue, 14 Jul 2020 09:02:40 -0700 (PDT) Received: from localhost.localdomain ([111.119.188.15]) by smtp.gmail.com with ESMTPSA id h10sm14585873eds.0.2020.07.14.09.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 09:02:40 -0700 (PDT) From: Muhammad Bilal To: beilei.xing@intel.com Cc: xiaolong.ye@intel.com, dev@dpdk.org, stable@dpdk.org, Muhammad Bilal , zijie.pan@6wind.com Date: Tue, 14 Jul 2020 20:58:47 +0500 Message-Id: <20200714155847.51442-1-m.bilal@emumba.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] drivers/net/i40e: fixed misplaced arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Here I have corrected a misplaced argument of i40e_aq_get_phy_register() This was also evident after seeing the datatype of its arguments. Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e") Cc: zijie.pan@6wind.com Bugzilla ID: 506 Signed-off-by: Muhammad Bilal --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 970a31cb2..5fdfadf7b 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct rte_eth_dev *dev, } status = i40e_aq_get_phy_register(hw, I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE, - addr, offset, 1, &value, NULL); + addr, 1, offset, &value, NULL); if (status) return -EIO; data[i] = (uint8_t)value;