net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'
diff mbox series

Message ID 20200714113242.20306-1-sachin.saxena@oss.nxp.com
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series
  • net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'
Related show

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Sachin Saxena (OSS) July 14, 2020, 11:32 a.m. UTC
From: Sachin Saxena <sachin.saxena@oss.nxp.com>

Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ferruh Yigit July 14, 2020, 11:36 a.m. UTC | #1
On 7/14/2020 12:32 PM, Sachin Saxena (OSS) wrote:
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
> 
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index a58a17946..a0715e587 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -142,3 +142,6 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* pmd_dpaa: The API ``rte_pmd_dpaa_set_tx_loopback`` will have extended ``port_id``
> +  definition from uint8_t to uint16_t.
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Hemant Agrawal July 14, 2020, 11:57 a.m. UTC | #2
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
Sent: Tuesday, July 14, 2020 5:07 PM
To: Sachin Saxena (OSS) <sachin.saxena@oss.nxp.com>; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'

On 7/14/2020 12:32 PM, Sachin Saxena (OSS) wrote:
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
> 
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index a58a17946..a0715e587 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -142,3 +142,6 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* pmd_dpaa: The API ``rte_pmd_dpaa_set_tx_loopback`` will have extended ``port_id``
> +  definition from uint8_t to uint16_t.
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Yang, Zhiyong July 23, 2020, 9:23 a.m. UTC | #3
Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Sachin Saxena (OSS)
Sent: Tuesday, July 14, 2020 7:33 PM
To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH] net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'

From: Sachin Saxena <sachin.saxena@oss.nxp.com>

Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index a58a17946..a0715e587 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -142,3 +142,6 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* pmd_dpaa: The API ``rte_pmd_dpaa_set_tx_loopback`` will have extended ``port_id``
+  definition from uint8_t to uint16_t.
Ferruh Yigit July 23, 2020, 2:34 p.m. UTC | #4
On 7/23/2020 10:23 AM, Yang, Zhiyong wrote:

> 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Sachin Saxena (OSS)
> Sent: Tuesday, July 14, 2020 7:33 PM
> To: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [dpdk-dev] [PATCH] net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'
> 
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
> 
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>
>

Applied to dpdk-next-net/master, thanks.

Updated commit log as below:

    doc: announce dpaa specific API parameter change

    'port_id' storage size should be 'uint16_t', the API
    'rte_pmd_dpaa_set_tx_loopback()' has it as 'uint8_t' but fixing it is an
    ABI breakage, that is why planning the fix in v20.11 release where ABI
    breakage is allowed.

Patch
diff mbox series

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index a58a17946..a0715e587 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -142,3 +142,6 @@  Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* pmd_dpaa: The API ``rte_pmd_dpaa_set_tx_loopback`` will have extended ``port_id``
+  definition from uint8_t to uint16_t.